Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Commit

Permalink
For #24854: Add ability to delete an existing address.
Browse files Browse the repository at this point in the history
  • Loading branch information
mcarare committed May 3, 2022
1 parent 9a9f677 commit 3ada316
Show file tree
Hide file tree
Showing 3 changed files with 47 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ interface AddressEditorController {
*/
fun handleSaveAddress(addressFields: UpdatableAddressFields)

/**
* @see [AddressEditorInteractor.onDeleteAddress]
*/
fun handleDeleteAddress(guid: String)

/**
* @see [AddressEditorInteractor.onUpdateAddress]
*/
Expand Down Expand Up @@ -63,6 +68,15 @@ class DefaultAddressEditorController(
}
}

override fun handleDeleteAddress(guid: String) {
lifecycleScope.launch {
storage.deleteAddress(guid)
lifecycleScope.launch(Dispatchers.Main) {
navController.popBackStack()
}
}
}

override fun handleUpdateAddress(guid: String, addressFields: UpdatableAddressFields) {
lifecycleScope.launch {
storage.updateAddress(guid, addressFields)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

package org.mozilla.fenix.settings.address.interactor

import mozilla.components.concept.storage.Address
import mozilla.components.concept.storage.UpdatableAddressFields
import org.mozilla.fenix.settings.address.controller.AddressEditorController

Expand All @@ -26,6 +27,14 @@ interface AddressEditorInteractor {
*/
fun onSaveAddress(addressFields: UpdatableAddressFields)

/**
* Deletes the provided address from the autofill storage. Called when a user
* taps on the save menu item or "Save" button.
*
* @param address An [Address] record to delete.
*/
fun onDeleteAddress(guid: String)

/**
* Updates the provided address in the autofill storage. Called when a user
* taps on the update menu item or "Update" button.
Expand Down Expand Up @@ -53,6 +62,10 @@ class DefaultAddressEditorInteractor(
controller.handleSaveAddress(addressFields)
}

override fun onDeleteAddress(guid: String) {
controller.handleDeleteAddress(guid)
}

override fun onUpdateAddress(guid: String, addressFields: UpdatableAddressFields) {
controller.handleUpdateAddress(guid, addressFields)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,13 @@ class AddressEditorView(
binding.emailInput.setText(address.email)
binding.phoneInput.setText(address.tel)
binding.fullNameInput.setText(address.givenName)

binding.deleteButton.apply {
isVisible = true
setOnClickListener { view ->
showConfirmDeleteAddressDialog(view.context, address)
}
}
}
}

Expand Down Expand Up @@ -75,4 +82,17 @@ class AddressEditorView(
interactor.onSaveAddress(addressFields)
}
}

private fun showConfirmDeleteAddressDialog(context: Context, address: Address) {
AlertDialog.Builder(context).apply {
setMessage(R.string.addressess_confirm_dialog_message)
setNegativeButton(R.string.addressess_confirm_dialog_cancel_button) { dialog: DialogInterface, _ ->
dialog.cancel()
}
setPositiveButton(R.string.addressess_confirm_dialog_ok_button) { _, _ ->
interactor.onDeleteAddress(address.guid)
}
create()
}.show()
}
}

0 comments on commit 3ada316

Please sign in to comment.