This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
For #9299: Get download notification accent color from fenix to match theme #9300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 26, 2020
Closed
hkaancaliskan
changed the title
Amejia481
suggested changes
Jan 5, 2021
There was a problem hiding this comment.
Thanks for this patch, great job, I added some comments for minor modification, additionally we could add an entry to the changelog file.
...downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt
Outdated
Show resolved
Hide resolved
...downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt
Outdated
Show resolved
Hide resolved
...downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt
Outdated
Show resolved
Hide resolved
...downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt
Outdated
Show resolved
Hide resolved
...feature/downloads/src/main/java/mozilla/components/feature/downloads/DownloadNotification.kt
Show resolved
Hide resolved
Amejia481
added
the
✏️ needs changes
Amejia481
reviewed
Jan 5, 2021
...downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt
Outdated
Show resolved
Hide resolved
|
@Amejia481 I'm ready for round 2 😊 |
Amejia481
reviewed
Jan 6, 2021
...ure/downloads/src/test/java/mozilla/components/feature/downloads/DownloadNotificationTest.kt
Outdated
Show resolved
Hide resolved
Amejia481
reviewed
Jan 6, 2021
Amejia481
reviewed
Jan 6, 2021
...ure/downloads/src/test/java/mozilla/components/feature/downloads/DownloadNotificationTest.kt
Outdated
Show resolved
Hide resolved
|
@hakkikaancaliskan great job, I think we only need to do some minor changes and squash the commits and it will be ready for lading 🚢 ! |
|
@Amejia481 I think it's all done, could you please re-check? |
Amejia481
added
🛬 needs landing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fenix side: mozilla-mobile/fenix#17231
Warning to reviewer: I'm amateur. Please double check everything 😊
Pull Request checklist
After merge