This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Closes #8751: Added methods to rename top site entries #8799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts when rebasing. Could you fix it @lorenzos? 🙏 |
lorenzos
changed the title
gabrielluong
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
@lorenzos Good job, this looks excellent. I just had one repeating comment about an ordering of the methods to keep the add/remove pairing closer together. Hope that is ok
...feature/top-sites/src/test/java/mozilla/components/feature/top/sites/TopSitesUseCasesTest.kt
Outdated
Show resolved
Hide resolved
...nts/feature/top-sites/src/main/java/mozilla/components/feature/top/sites/TopSitesUseCases.kt
Outdated
Show resolved
Hide resolved
...nts/feature/top-sites/src/main/java/mozilla/components/feature/top/sites/TopSitesUseCases.kt
Outdated
Show resolved
Hide resolved
...ents/feature/top-sites/src/main/java/mozilla/components/feature/top/sites/TopSitesStorage.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Gabriel Luong <[email protected]>
gabrielluong
approved these changes
Oct 27, 2020
gabrielluong
added
the
🛬 needs landing (squash)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8751.