Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes issue #7983: Generate a file name when the content provider doesn't provide one. #8104

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

Amejia481
Copy link
Contributor

When we get an uri from a file provider, we were trusting the provider to always provide a valid file name (DISPLAY_NAME) that is not always true, as we can see crashes on #7983, now when we can't find the file name, we are trying to generate a file name as it's required for the file to be updated.


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Aug 12, 2020
@Amejia481 Amejia481 requested a review from pocmo August 12, 2020 20:03
@Amejia481 Amejia481 force-pushed the issue-7983 branch 2 times, most recently from bf62df7 to b9e694a Compare August 13, 2020 15:39
@Amejia481
Copy link
Contributor Author

bors r=pocmo

@bors
Copy link

bors bot commented Aug 17, 2020

Build succeeded:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants