Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Re-enable GeckoViewFetchTestCases.get200WithCookiePolicy(). #7688

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Re-enable GeckoViewFetchTestCases.get200WithCookiePolicy(). #7688

merged 1 commit into from
Jul 13, 2020

Conversation

pocmo
Copy link
Contributor

@pocmo pocmo commented Jul 13, 2020

The GeckoView bug was fixed and the test is now passing again.

@pocmo pocmo added the 🕵️‍♀️ needs review PRs that need to be reviewed label Jul 13, 2020
@pocmo
Copy link
Contributor Author

pocmo commented Jul 13, 2020

bors try

bors bot pushed a commit that referenced this pull request Jul 13, 2020
@MozLando
Try #7688:
dfbed0f
@bors
Copy link

bors bot commented Jul 13, 2020

try

Build failed:

@pocmo
Re-enable GeckoViewFetchTestCases.get200WithCookiePolicy().
5ed2f7c 
The GeckoView bug was fixed and the test is now passing again.
@pocmo pocmo force-pushed the geckoview-cookie-test branch from 6c5b456 to 5ed2f7c Compare July 13, 2020 13:26
@Amejia481
Copy link
Contributor

There is a ktlint nit

[task 2020-07-13T10:30:48.770Z] > Task :ktlint
[task 2020-07-13T10:30:48.770Z] /builds/worker/checkouts/src/components/browser/engine-gecko-nightly/src/androidTest/java/mozilla/components/browser/engine/gecko/fetch/geckoview/GeckoViewFetchTestCases.kt:13:1: Unused import
[task 2020-07-13T10:30:51.769Z] 
[task 2020-07-13T10:30:51.769Z] > Task :ktlint FAILED
[task 2020-07-13T10:30:51.769Z] 
[task 2020-07-13T10:30:51.769Z] FAILURE: Build failed with an exception.

@Amejia481 Amejia481 self-assigned this Jul 13, 2020
@pocmo
Copy link
Contributor Author

pocmo commented Jul 13, 2020

Already pushed a fix :)

@Amejia481
Copy link
Contributor

bors try

bors bot pushed a commit that referenced this pull request Jul 13, 2020
@MozLando
Try #7688:
f028209
@bors
Copy link

bors bot commented Jul 13, 2020

try

Build succeeded:

@pocmo
Copy link
Contributor Author

pocmo commented Jul 13, 2020

bors r=Amejia481

@bors
Copy link

bors bot commented Jul 13, 2020

Build succeeded:

@bors bors bot merged commit f074469 into mozilla-mobile:master Jul 13, 2020
@pocmo pocmo deleted the geckoview-cookie-test branch July 13, 2020 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Amejia481 Amejia481 Amejia481 approved these changes

Assignees

@Amejia481 Amejia481

Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pocmo @Amejia481