Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Upgrade Glean to v31.1.0 #7336

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Upgrade Glean to v31.1.0 #7336

merged 1 commit into from
Jun 12, 2020

Conversation

badboy
Copy link
Member

@badboy badboy commented Jun 11, 2020


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@badboy
Copy link
Member Author

badboy commented Jun 11, 2020

bors r=Dexterp37

bors bot pushed a commit that referenced this pull request Jun 11, 2020
7336: Upgrade Glean to v31.1.0 r=Dexterp37 a=badboy



Co-authored-by: Jan-Erik Rediger <[email protected]>
@bors
Copy link

bors bot commented Jun 11, 2020

Timed out.

@badboy
Copy link
Member Author

badboy commented Jun 11, 2020

bors retry

bors bot pushed a commit that referenced this pull request Jun 11, 2020
7336: Upgrade Glean to v31.1.0 r=Dexterp37 a=badboy



Co-authored-by: Jan-Erik Rediger <[email protected]>
@bors
Copy link

bors bot commented Jun 11, 2020

Timed out.

@badboy
Copy link
Member Author

badboy commented Jun 11, 2020

Lint error:

[task 2020-06-11T11:36:04.763Z]   Errors found:
[task 2020-06-11T11:36:04.763Z]   
[task 2020-06-11T11:36:04.763Z]   /builds/worker/checkouts/src/samples/sync/src/main/res/layout/activity_main.xml:133: Error: Replace the <fragment> tag with FragmentContainerView. [FragmentTagUsage]
[task 2020-06-11T11:36:04.764Z]               <fragment android:name="org.mozilla.samples.sync.DeviceFragment"
[task 2020-06-11T11:36:04.764Z]                ~~~~~~~~

@grigoryk You touched that part last, you might want to have a look. I simply applied the suggestion.

@badboy
Copy link
Member Author

badboy commented Jun 12, 2020

Great, I managed to not push it last night.

@badboy
Copy link
Member Author

badboy commented Jun 12, 2020

bors r=Dexterp37

bors bot pushed a commit that referenced this pull request Jun 12, 2020
7336: Upgrade Glean to v31.1.0 r=Dexterp37 a=badboy



Co-authored-by: Jan-Erik Rediger <[email protected]>
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #7336 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7336      +/-   ##
============================================
- Coverage     77.41%   77.36%   -0.06%     
+ Complexity     5072     5025      -47     
============================================
  Files           675      671       -4     
  Lines         24787    24586     -201     
  Branches       3663     3637      -26     
============================================
- Hits          19190    19021     -169     
+ Misses         4090     4070      -20     
+ Partials       1507     1495      -12     
Impacted Files Coverage Δ Complexity Δ
...s/support/webextensions/facts/WebExtensionFacts.kt
.../support/webextensions/WebExtensionPopupFeature.kt
...ts/support/webextensions/WebExtensionController.kt
...nents/support/webextensions/WebExtensionSupport.kt

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df1ee8...7e44933. Read the comment docs.

@bors
Copy link

bors bot commented Jun 12, 2020

Build failed:

@badboy
Copy link
Member Author

badboy commented Jun 12, 2020

bors r=Dexterp37

@bors
Copy link

bors bot commented Jun 12, 2020

Build succeeded:

@bors bors bot merged commit d13bc14 into mozilla-mobile:master Jun 12, 2020
@badboy badboy deleted the glean-31.1.0 branch June 12, 2020 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants