Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Update Glean to include new upload mechanism (& gzip) #7209

Merged
merged 3 commits into from
Jun 3, 2020

Conversation

badboy
Copy link
Member

@badboy badboy commented Jun 2, 2020


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

This brings with it the new upload mechanism.
@badboy badboy requested review from Dexterp37 and brizental June 2, 2020 08:14
Copy link
Contributor

@brizental brizental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Dexterp37 Dexterp37 removed their request for review June 3, 2020 07:39
@badboy
Copy link
Member Author

badboy commented Jun 3, 2020

bors r=brizental

bors bot pushed a commit that referenced this pull request Jun 3, 2020
7209: Update Glean to include new upload mechanism (& gzip) r=brizental a=badboy



Co-authored-by: Jan-Erik Rediger <[email protected]>
@pocmo
Copy link
Contributor

pocmo commented Jun 3, 2020

[task 2020-06-03T11:42:39.981Z] > Task :ktlint
[task 2020-06-03T11:42:39.981Z] /builds/worker/checkouts/src/components/service/glean/src/main/java/mozilla/components/service/glean/net/ConceptFetchHttpUploader.kt:13:1: Unused import
[task 2020-06-03T11:42:39.981Z] /builds/worker/checkouts/src/components/service/glean/src/main/java/mozilla/components/service/glean/net/ConceptFetchHttpUploader.kt:14:1: Unused import

@pocmo pocmo added the ✏️ needs changes PRs that need some changes/fixes before they can land label Jun 3, 2020
@badboy
Copy link
Member Author

badboy commented Jun 3, 2020

[task 2020-06-03T11:42:39.981Z] > Task :ktlint
[task 2020-06-03T11:42:39.981Z] /builds/worker/checkouts/src/components/service/glean/src/main/java/mozilla/components/service/glean/net/ConceptFetchHttpUploader.kt:13:1: Unused import
[task 2020-06-03T11:42:39.981Z] /builds/worker/checkouts/src/components/service/glean/src/main/java/mozilla/components/service/glean/net/ConceptFetchHttpUploader.kt:14:1: Unused import

Gnah. Thanks for the notice. Thought I did run that. Will fix it locally, run the lints and push again.

@bors
Copy link

bors bot commented Jun 3, 2020

Timed out.

@badboy badboy force-pushed the update-glean-with-upload branch from 93397e3 to 7a18bd8 Compare June 3, 2020 13:30
@badboy
Copy link
Member Author

badboy commented Jun 3, 2020

bors r=brizental

bors bot pushed a commit that referenced this pull request Jun 3, 2020
7209: Update Glean to include new upload mechanism (& gzip) r=brizental a=badboy



Co-authored-by: Jan-Erik Rediger <[email protected]>
@bors
Copy link

bors bot commented Jun 3, 2020

Build failed:

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #7209 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7209      +/-   ##
============================================
- Coverage     77.38%   77.01%   -0.37%     
+ Complexity     5007     4862     -145     
============================================
  Files           668      652      -16     
  Lines         24473    24189     -284     
  Branches       3623     3569      -54     
============================================
- Hits          18938    18629     -309     
- Misses         4051     4093      +42     
+ Partials       1484     1467      -17     
Impacted Files Coverage Δ Complexity Δ
...illa/components/feature/session/HistoryDelegate.kt
.../components/feature/intent/ext/IntentExtensions.kt
...zilla/components/feature/session/SessionFeature.kt
.../components/feature/session/SwipeRefreshFeature.kt
...a/components/service/glean/config/Configuration.kt
.../feature/readerview/view/ReaderViewControlsView.kt
...s/feature/readerview/view/ReaderViewControlsBar.kt
...ponents/feature/session/PictureInPictureFeature.kt
...ts/feature/intent/processing/TabIntentProcessor.kt
...ents/feature/session/TrackingProtectionUseCases.kt
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bf105...9383083. Read the comment docs.

@badboy badboy force-pushed the update-glean-with-upload branch from 7a18bd8 to 9383083 Compare June 3, 2020 14:31
@badboy
Copy link
Member Author

badboy commented Jun 3, 2020

bors r=brizental

One more try, ran both lint and tests locally.

@bors
Copy link

bors bot commented Jun 3, 2020

Build succeeded:

@bors bors bot merged commit fc17511 into mozilla-mobile:master Jun 3, 2020
@badboy badboy deleted the update-glean-with-upload branch June 4, 2021 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✏️ needs changes PRs that need some changes/fixes before they can land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants