Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Issue 7170: Make ThumbnailsUseCases optional in TabsFeature and TabsTrayPresenter #7171

Merged
merged 1 commit into from
May 29, 2020

Conversation

gabrielluong
Copy link
Member


Fixes #7170. This also rolls back the changes to the TabsTrayPresenterTest from #7021, which are not necessary if we made ThumbnailsUseCases optional.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@gabrielluong gabrielluong requested a review from jonalmeida May 29, 2020 04:04
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #7171 into master will decrease coverage by 0.33%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7171      +/-   ##
============================================
- Coverage     77.26%   76.92%   -0.34%     
+ Complexity     5048     4890     -158     
============================================
  Files           675      662      -13     
  Lines         24707    23858     -849     
  Branches       3641     3490     -151     
============================================
- Hits          19090    18353     -737     
+ Misses         4111     4045      -66     
+ Partials       1506     1460      -46     
Impacted Files Coverage Δ Complexity Δ
...la/components/feature/tabs/tabstray/TabsFeature.kt 90.90% <0.00%> (-4.33%) 7.00 <0.00> (ø)
...ponents/feature/tabs/tabstray/TabsTrayPresenter.kt 94.28% <100.00%> (+0.16%) 10.00 <1.00> (+1.00)
.../feature/downloads/AbstractFetchDownloadService.kt 68.00% <0.00%> (-1.10%) 63.00% <0.00%> (ø%)
...ents/support/migration/MigrationIntentProcessor.kt 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
...onents/support/sync/telemetry/BaseGleanSyncPing.kt 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
...components/lib/jexl/evaluator/EvaluatorHandlers.kt
.../src/main/java/mozilla/components/lib/jexl/Jexl.kt
...in/java/mozilla/components/lib/jexl/lexer/Token.kt
.../mozilla/components/lib/jexl/ext/JexlExtensions.kt
...mozilla/components/lib/jexl/evaluator/Evaluator.kt
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc5089...b674ac1. Read the comment docs.

@jonalmeida
Copy link
Contributor

bors r+

@bors
Copy link

bors bot commented May 29, 2020

Build succeeded:

@bors bors bot merged commit 2a18bde into mozilla-mobile:master May 29, 2020
@gabrielluong gabrielluong deleted the 7170 branch June 4, 2020 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ThumbnailsUseCases optional in TabsFeature and TabsTrayPresenter
2 participants