Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Make sure the bottom toolbar is never stuck invisible #7102

Merged
merged 1 commit into from
May 29, 2020

Conversation

miDeb
Copy link
Contributor

@miDeb miDeb commented May 25, 2020

Closes #7101. This is my attempt to solve this issue. Essentially, if the user is scrolling upwards, but the toolbar is not being scrolled and not already showing or animating up, just forceExpand it.


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #7102 into master will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7102   +/-   ##
=========================================
  Coverage     77.01%   77.02%           
- Complexity     4899     4903    +4     
=========================================
  Files           654      654           
  Lines         24150    24165   +15     
  Branches       3543     3546    +3     
=========================================
+ Hits          18599    18612   +13     
  Misses         4062     4062           
- Partials       1489     1491    +2     
Impacted Files Coverage Δ Complexity Δ
...r/toolbar/behavior/BrowserToolbarBottomBehavior.kt 78.33% <60.00%> (-1.67%) 27.00 <0.00> (+3.00) ⬇️
...lla/components/support/migration/AddonMigration.kt 96.05% <0.00%> (+0.59%) 11.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c8823...3307103. Read the comment docs.

@Amejia481 Amejia481 requested a review from jonalmeida May 26, 2020 15:18
@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label May 26, 2020
@pocmo pocmo requested a review from Mugurell May 26, 2020 15:18
@Mugurell
Copy link
Contributor

Thank you @miDeb , the patch looks good!
I see some CI tasks failed because of missing dependencies, closing and reopening the PR just to have them run again.

@Mugurell Mugurell closed this May 29, 2020
@Mugurell Mugurell reopened this May 29, 2020
Copy link
Contributor

@Mugurell Mugurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @miDeb !
Indeed, there are some edgecases described here https://bugzilla.mozilla.org/show_bug.cgi?id=1633322 for which we don't really have a solution.
Ignoring the GV state for this particular edgecase seems like the best approach in the meantime to make sure users cannot be stucked without a toolbar.
Nice patch 👍!

@jonalmeida
Copy link
Contributor

bors r=Mugurell

@bors
Copy link

bors bot commented May 29, 2020

Build succeeded:

@bors bors bot merged commit cb312ff into mozilla-mobile:master May 29, 2020
@miDeb miDeb deleted the bottom_toolbar_snap branch May 29, 2020 16:18
@miDeb
Copy link
Contributor Author

miDeb commented May 29, 2020

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The bottom toolbar can get into a state where it is difficult to get it to show again
4 participants