This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Issue #2985: Add fallback in case Promise.any not available #7044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonalmeida
approved these changes
May 20, 2020
|
bors r=jonalmeida |
bors bot
pushed a commit
that referenced
this pull request
May 20, 2020
7031: Closes #5249: Long URI in the address bar will hang the UI r=pocmo a=csadilek We've had two cases now where this was a problem. A bookmarklet (see #6985) and a data URI (#5249). This fix is similar to the one we landed last week for our Awesomebar (csadilek@bba846d), but tapping on long URLs or copying them from the clipboard etc. would still cause the UI to hang. With data URIs I can reproduce seconds/minutes long hangs that are fixed with this. Took this from Fennec (https://github.com/pocmo/fennec-graveyard/blob/master/mobile/android/chrome/content/browser.js#L4308), and applied to both display and edit toolbar (otherwise the UI would hang once the toolbar is in edit mode). 7044: Issue #2985: Add fallback in case Promise.any not available r=jonalmeida a=csadilek This is handling `promise.any` not being available (current beta). The only part we miss is the optimization to let the faster operation of fetch|cache win, but that's fine for now. Co-authored-by: Christian Sadilek <[email protected]>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
May 20, 2020
7044: Issue #2985: Add fallback in case Promise.any not available r=jonalmeida a=csadilek This is handling `promise.any` not being available (current beta). The only part we miss is the optimization to let the faster operation of fetch|cache win, but that's fine for now. Co-authored-by: Christian Sadilek <[email protected]>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is handling
promise.anynot being available (current beta). The only part we miss is the optimization to let the faster operation of fetch|cache win, but that's fine for now.