Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Issue #1705: Allow CrashReporterService to return a unique identifier for reported crashes. #6738

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

pocmo
Copy link
Contributor

@pocmo pocmo commented Apr 22, 2020

This is one small piece of #1705. I am going to land some pieces independently to avoid ending up with a huge patch.

Here we are allowing a CrashReporterService to return an ID that we can later use to lookup that crash. For Socorro we return the crash ID that we get when uploading. We can later use that to create a URL pointing to this crash. For Sentry we return the UUID of the event. We can at least ask Sentry with this UUID for the actual crash URL.

@pocmo pocmo added the 🕵️‍♀️ needs review PRs that need to be reviewed label Apr 22, 2020
@pocmo pocmo requested a review from rocketsroger April 22, 2020 12:56
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #6738 into master will decrease coverage by 0.60%.
The diff coverage is 91.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6738      +/-   ##
============================================
- Coverage     77.58%   76.98%   -0.61%     
+ Complexity     4742     4212     -530     
============================================
  Files           629      548      -81     
  Lines         23156    20713    -2443     
  Branches       3413     3033     -380     
============================================
- Hits          17965    15945    -2020     
+ Misses         3779     3488     -291     
+ Partials       1412     1280     -132     
Impacted Files Coverage Δ Complexity Δ
...ponents/lib/crash/service/MozillaSocorroService.kt 81.99% <88.23%> (+0.17%) 35.00 <4.00> (ø)
...nts/lib/crash/service/GleanCrashReporterService.kt 81.48% <100.00%> (+1.08%) 21.00 <0.00> (ø)
...illa/components/lib/crash/service/SentryService.kt 81.25% <100.00%> (+2.30%) 9.00 <0.00> (ø)
...ponents/support/migration/MigrationResultsStore.kt 79.06% <0.00%> (-0.10%) 14.00% <0.00%> (+2.00%) ⬇️
...omponents/feature/accounts/push/SendTabUseCases.kt
...illa/components/browser/menu/BrowserMenuBuilder.kt
...nents/feature/downloads/manager/DownloadManager.kt
...er/state/reducer/TrackingProtectionStateReducer.kt
...onents/feature/downloads/DownloadDialogFragment.kt
...nts/feature/accounts/push/FxaPushSupportFeature.kt
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab2ccd1...593c29e. Read the comment docs.

@pocmo pocmo changed the title Issue #1705: Alloww CrashReporterService to return a unique identifier for reported crashes. Issue #1705: Allow CrashReporterService to return a unique identifier for reported crashes. Apr 22, 2020
Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@rocketsroger rocketsroger added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Apr 24, 2020
@pocmo
Copy link
Contributor Author

pocmo commented Apr 27, 2020

bors r=rocketsroger

@bors
Copy link

bors bot commented Apr 27, 2020

Build succeeded:

@bors bors bot merged commit bcd7245 into mozilla-mobile:master Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants