Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Issue #6314: Support fetching non base64 encoded data URIs #6561

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

csadilek
Copy link
Contributor

@csadilek csadilek commented Apr 7, 2020

Simple change to support data URI that are not base64 encoded. With this backup/restore is now finally working in uBlock.

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #6561 into master will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6561      +/-   ##
============================================
- Coverage     77.68%   77.58%   -0.10%     
+ Complexity     4710     4635      -75     
============================================
  Files           626      618       -8     
  Lines         22925    22588     -337     
  Branches       3372     3327      -45     
============================================
- Hits          17809    17525     -284     
+ Misses         3740     3712      -28     
+ Partials       1376     1351      -25     
Impacted Files Coverage Δ Complexity Δ
...in/java/mozilla/components/concept/fetch/Client.kt 22.58% <0.00%> (-4.35%) 2.00 <0.00> (ø)
...a/components/support/migration/TelemetryHelpers.kt 88.17% <0.00%> (-0.96%) 0.00% <0.00%> (ø%)
...ents/support/migration/MigrationIntentProcessor.kt 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
...onents/support/sync/telemetry/BaseGleanSyncPing.kt 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
...components/feature/toolbar/internal/URLRenderer.kt
...lla/components/feature/toolbar/ToolbarPresenter.kt
.../mozilla/components/lib/nearby/NearbyConnection.kt
...la/components/feature/toolbar/ToolbarInteractor.kt
...nents/feature/toolbar/WebExtensionToolbarAction.kt
...ents/feature/toolbar/WebExtensionToolbarFeature.kt
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c4fc12...40a09a2. Read the comment docs.

Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@csadilek
Copy link
Contributor Author

csadilek commented Apr 7, 2020

bors r=Amejia481

@bors
Copy link

bors bot commented Apr 7, 2020

Build succeeded

@bors bors bot merged commit 4c77753 into mozilla-mobile:master Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants