Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Bug 1622339 - Move android-sdk installation into a toolchain task #6449

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

JohanLorenzo
Copy link
Contributor


Backports mozilla-mobile/fenix#9394 and mozilla-mobile/reference-browser#1082.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@JohanLorenzo JohanLorenzo requested a review from tomprince March 30, 2020 12:58
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #6449 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6449      +/-   ##
============================================
+ Coverage     77.50%   77.54%   +0.03%     
- Complexity     4562     4675     +113     
============================================
  Files           620      623       +3     
  Lines         22445    22803     +358     
  Branches       3299     3364      +65     
============================================
+ Hits          17397    17683     +286     
- Misses         3697     3743      +46     
- Partials       1351     1377      +26     
Impacted Files Coverage Δ Complexity Δ
...onents/support/sync/telemetry/BaseGleanSyncPing.kt 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
...ts/support/webextensions/WebExtensionController.kt
.../support/webextensions/WebExtensionPopupFeature.kt
...nents/support/webextensions/WebExtensionSupport.kt
...s/support/webextensions/facts/WebExtensionFacts.kt
.../feature/sitepermissions/SitePermissionsFeature.kt 85.77% <0.00%> (ø) 81.00% <0.00%> (?%)
...ponents/feature/sitepermissions/SitePermissions.kt 78.57% <0.00%> (ø) 17.00% <0.00%> (?%)
...e/sitepermissions/SitePermissionsDialogFragment.kt 81.31% <0.00%> (ø) 23.00% <0.00%> (?%)
...ts/feature/sitepermissions/SitePermissionsRules.kt 73.07% <0.00%> (ø) 20.00% <0.00%> (?%)
...eature/sitepermissions/db/SitePermissionsEntity.kt 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ca085...8b13bab. Read the comment docs.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 30, 2020

linux64-android-sdk-linux-repack:
attributes:
artifact_prefix: mobile/android-sdk

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it's not! I removed it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it turns out to be needed! Otherwise, the sdk ends up in the public/build folder: https://firefox-ci-tc.services.mozilla.com/tasks/H7VhhRRXQZuhtk1c0ytlCQ#artifacts

run:
using: index-search
run-on-projects: []
worker-type: always-optimized

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should match what we did elsewhere here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@JohanLorenzo JohanLorenzo force-pushed the bug-1622339 branch 2 times, most recently from 94dfc67 to b2ea9f6 Compare April 9, 2020 13:57
@JohanLorenzo JohanLorenzo removed the 🕵️‍♀️ needs review PRs that need to be reviewed label Apr 9, 2020
@JohanLorenzo
Copy link
Contributor Author

bors r=tomprince

@bors
Copy link

bors bot commented Apr 9, 2020

Build succeeded

@bors bors bot merged commit 4ebfff7 into mozilla-mobile:master Apr 9, 2020
@JohanLorenzo JohanLorenzo deleted the bug-1622339 branch April 16, 2020 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants