-
Notifications
You must be signed in to change notification settings - Fork 472
Bug 1622339 - Move android-sdk installation into a toolchain task #6449
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6449 +/- ##
============================================
+ Coverage 77.50% 77.54% +0.03%
- Complexity 4562 4675 +113
============================================
Files 620 623 +3
Lines 22445 22803 +358
Branches 3299 3364 +65
============================================
+ Hits 17397 17683 +286
- Misses 3697 3743 +46
- Partials 1351 1377 +26
Continue to review full report at Codecov.
|
|
||
linux64-android-sdk-linux-repack: | ||
attributes: | ||
artifact_prefix: mobile/android-sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it's not! I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it turns out to be needed! Otherwise, the sdk ends up in the public/build
folder: https://firefox-ci-tc.services.mozilla.com/tasks/H7VhhRRXQZuhtk1c0ytlCQ#artifacts
taskcluster/ci/toolchain/kind.yml
Outdated
run: | ||
using: index-search | ||
run-on-projects: [] | ||
worker-type: always-optimized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should match what we did elsewhere here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
94dfc67
to
b2ea9f6
Compare
b2ea9f6
to
8b13bab
Compare
bors r=tomprince |
Build succeeded |
Backports mozilla-mobile/fenix#9394 and mozilla-mobile/reference-browser#1082.
Pull Request checklist
After merge