This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Migrate the Glean SDK to the Rust implementation #4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
reviewed
Oct 3, 2019
components/service/glean/src/main/java/mozilla/components/service/glean/Glean.kt
Outdated
Show resolved
Hide resolved
mdboom
approved these changes
Oct 3, 2019
travis79
suggested changes
Oct 3, 2019
Yes, it's meant to be removed after the library is available on Maven (see the TODO in the PR description) |
Sorry, I totally overlooked the TODO. This makes sense, I just thought it was weird to include a binary and wanted to make sure. |
travis79
approved these changes
Oct 3, 2019
Dexterp37
force-pushed
the
gleancore_migration
branch
2 times, most recently
from
5409fda to
54a6643
Compare
Codecov Report
@@ Coverage Diff @@
## master #4620 +/- ##
============================================
- Coverage 81.35% 80.47% -0.89%
+ Complexity 4377 3907 -470
============================================
Files 561 511 -50
Lines 19087 17190 -1897
Branches 2782 2514 -268
============================================
- Hits 15529 13833 -1696
+ Misses 2439 2339 -100
+ Partials 1119 1018 -101
Continue to review full report at Codecov.
|
Dexterp37
force-pushed
the
gleancore_migration
branch
from
5aacd7a to
360a47c
Compare
Dexterp37
force-pushed
the
gleancore_migration
branch
2 times, most recently
from
1f4cab0 to
ae0a1f3
Compare
Dexterp37
force-pushed
the
gleancore_migration
branch
4 times, most recently
from
7aaed8a to
766a6b9
Compare
Dexterp37
force-pushed
the
gleancore_migration
branch
3 times, most recently
from
1e06c40 to
82620f9
Compare
badboy
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
I built locally against this PR and even generated the Fenix APKs we used for testing and QA.
This seems to be all working.
The remaining steps:
- Remove the
mavenLocal()line - Wait for our Maven release
- Re-base and push this PR again to trigger CI
- Squash the commits into something reasonable
This was referenced Oct 22, 2019
Dexterp37
force-pushed
the
gleancore_migration
branch
2 times, most recently
from
dd1c78d to
661a33e
Compare
This removes the Kotlin implementation from this repository and introduces type aliases that point to the Rust implementation, which is now a new dependency.
Dexterp37
force-pushed
the
gleancore_migration
branch
from
661a33e to
12163f1
Compare
|
bors=mdboom,travis79,badboy |
bors bot
pushed a commit
that referenced
this pull request
Oct 24, 2019
4620: Migrate the Glean SDK to the Rust implementation r=Dexterp37 a=Dexterp37 This completely removes the Kotlin implementation of the Glean SDK from this repository. It introduces aliases that are used instead. Please note that integration tests keep living in this repository as part of the [Glean sample app](https://github.com/mozilla-mobile/android-components/tree/master/samples/glean/src/androidTest/java/org/mozilla/samples/glean). **Note: this is a massive PR with deletion, mostly. I'd recommend reviewing it commit-by-commit** **TODO** - [x] remove the glean binary; - [x] depend on the maven version of the Glean SDK. Co-authored-by: Alessio Placitelli <[email protected]>
Build succeeded
|
6 tasks
bors bot
pushed a commit
that referenced
this pull request
Oct 30, 2019
4892: Add back the @jvmoverloads to the Glean SDK public API r=Dexterp37 a=Dexterp37 This additionally adds unit testing in Java to make sure we're not regressing this again. Note: this restores the annotations that were removed by #4620 Co-authored-by: Alessio Placitelli <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Oct 30, 2019
4892: Add back the @jvmoverloads to the Glean SDK public API r=Dexterp37 a=Dexterp37 This additionally adds unit testing in Java to make sure we're not regressing this again. Note: this restores the annotations that were removed by #4620 Co-authored-by: Alessio Placitelli <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Oct 30, 2019
4892: Add back the @jvmoverloads to the Glean SDK public API r=Dexterp37 a=Dexterp37 This additionally adds unit testing in Java to make sure we're not regressing this again. Note: this restores the annotations that were removed by #4620 Co-authored-by: Alessio Placitelli <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely removes the Kotlin implementation of the Glean SDK from this repository. It introduces aliases that are used instead.
Please note that integration tests keep living in this repository as part of the Glean sample app.
Note: this is a massive PR with deletion, mostly. I'd recommend reviewing it commit-by-commit
TODO
Pull Request checklist
After merge