Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #4191: Fixed the recommended() tracking category on SystemEngine #4196

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Closes #4191: Fixed the recommended() tracking category on SystemEngine #4196

merged 1 commit into from
Aug 26, 2019

Conversation

Amejia481
Copy link
Contributor

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 requested a review from mcomella August 24, 2019 06:16
@Amejia481 Amejia481 requested a review from a team as a code owner August 24, 2019 06:16
pocmo
pocmo approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bors r+

bors bot pushed a commit that referenced this pull request Aug 26, 2019
@MozLando @Amejia481
Merge #4196
6f40f6f 
4196: Closes #4191: Fixed the recommended() tracking category on SystemEngine r=pocmo a=Amejia481



Co-authored-by: Arturo Mejia <[email protected]>
@bors
Copy link

bors bot commented Aug 26, 2019

Build succeeded

@bors bors bot merged commit 4a6912d into mozilla-mobile:master Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pocmo pocmo pocmo approved these changes

@mcomella mcomella Awaiting requested review from mcomella

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amejia481 @pocmo