Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #4069: Update docs for newAccount param #4122

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Closes #4069: Update docs for newAccount param #4122

merged 1 commit into from
Aug 14, 2019

Conversation

jonalmeida
Copy link
Contributor

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@jonalmeida jonalmeida requested a review from grigoryk August 14, 2019 13:25
@jonalmeida jonalmeida requested a review from a team as a code owner August 14, 2019 13:25
@jonalmeida jonalmeida added the 🕵️‍♀️ needs review PRs that need to be reviewed label Aug 14, 2019
pocmo
pocmo approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you want to wait for Grisha. Otherwise ✅

@jonalmeida
Copy link
Contributor Author

Wasn't sure if the phrasing was accurate enough, but that's a fair point. Thanks!

@jonalmeida
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Aug 14, 2019
@MickeyMoz @jonalmeida
Merge #4122
cca2831 
4122: Closes #4069: Update docs for newAccount param r=jonalmeida a=jonalmeida



Co-authored-by: Jonathan Almeida <[email protected]>
@bors
Copy link

bors bot commented Aug 14, 2019

Build failed

@jonalmeida
Copy link
Contributor Author

bors retry

bors bot pushed a commit that referenced this pull request Aug 14, 2019
@MickeyMoz @jonalmeida
Merge #4122
9ad814d 
4122: Closes #4069: Update docs for newAccount param r=jonalmeida a=jonalmeida



Co-authored-by: Jonathan Almeida <[email protected]>
@bors
Copy link

bors bot commented Aug 14, 2019

Build succeeded

@bors bors bot merged commit 2a43a1e into mozilla-mobile:master Aug 14, 2019
@jonalmeida jonalmeida deleted the issue-4069 branch September 20, 2019 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pocmo pocmo pocmo approved these changes

@grigoryk grigoryk Awaiting requested review from grigoryk

Assignees
No one assigned
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonalmeida @pocmo