This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Closes #2243: Add engine API for WebExtension messaging #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csadilek
force-pushed
the
issue-2243
branch
3 times, most recently
from
2f28d64 to
dfa1cb8
Compare
|
Thanks so much for this PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in the web extension messaging functionality (+ tests and Kdoc).
I want to commit a working example with this so I added a simply bidirectional message exchange to our stub reader view feature. Once this PR lands, work on reader view will continue in #2624 and these simple example messages will replaced with the actual reader view messages.
As we now need the engine to return a
WebExtensioninstance (abstracting over the concrete engine-specific implementation), there is a slight API change to install extensions byidandurland pass along the installed web extension inonSuccess.