Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Upgrade version of nimbus-fml to 93.8.0 #12592

Merged
merged 5 commits into from
Aug 10, 2022
Merged

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Aug 2, 2022

Previous PR #12567 bounced when trying to build Focus on Android on CI only, with not much to go on: Focus live.log; Fenix live.log.

Can build on x86_64 Darwin, but seeing problems on x86_64-unknown-linux-musl.

I'm going to guess this needs investigation around reqwest and TLS in the Application Services repo.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Used by GitHub Actions.

@jhugman jhugman requested a review from a team as a code owner August 2, 2022 12:28
@jhugman jhugman added the do not land PRs that requires coordination before landing label Aug 2, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2022

This pull request has conflicts when rebasing. Could you fix it @jhugman? 🙏

@rvandermeulen
Copy link
Contributor

@jhugman Will you be updating this to the A-S 94.0.1 release now?

@travis79
Copy link
Member

@jhugman Will you be updating this to the A-S 94.0.1 release now?

James is out on PTO, I can take this over and update this to the new release

@travis79 travis79 removed the do not land PRs that requires coordination before landing label Aug 10, 2022
Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. My concern was around the TCP experiment with version 93.6.0, but we have that verified, so we can upgrade now.

@jonalmeida jonalmeida added the 🛬 needs landing PRs that are ready to land label Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants