For #12565 Implement the common part of search widget in Android Components

[iorgamgabriel]

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry or does not need one
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

• Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
• Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Fixes #12565

[Mugurell]

Just a quick driveby, this is looking great!

[Mugurell]

A-C should be "client agnostic" and not include the launcher icon of Fenix.
If this resource is really needed maybe we can set the source to be mozac_ic_globe.

[iorgamgabriel]

I added mozac_search_widget_icon that is an empty file . This file will be overridden in Focus and Fenix with the specific app icon .

[jonalmeida]

Looks really nice! Left a few comments below too.

[jonalmeida]

I think I missed this earlier - why do we need the permission to query all packages (apps) installed on the user's phone? This permission is very powerful and requires us to provide a reason on how we use it when submitting an app to the Play store.

The warning QueryAllPackagesPermission below is meant to make us aware of what we are requesting, so if we do need this permission here, we should at the very least leave a comment on how it's used. 🙂

[iorgamgabriel]

This is needed for intentSpeech.resolveActivity from
val intentSpeech = Intent(RecognizerIntent.ACTION_RECOGNIZE_SPEECH)

    return intentSpeech.resolveActivity(context.packageManager)?.let {
        PendingIntent.getActivity(
            context,
            REQUEST_CODE_VOICE, voiceIntent, PendingIntentUtils.defaultFlags
        )
    }

I can do this in manifest like in Focus and Fenix ,it's the same code or I can add this @SuppressLint("QueryPermissionsNeeded") to the method .
@jonalmeida

[jonalmeida]

@iorgamgabriel it's not clear to me from the docs why the component or the apps need to have this permission. Could you share a link to where this requirement is?

[iorgamgabriel]

Done I rewrote this code without resolveActivity

[iorgamgabriel]

This was needed for
val intentSpeech = Intent(RecognizerIntent.ACTION_RECOGNIZE_SPEECH)
intentSpeech.resolveActivity(context.packageManager)

to check if the phone has voice recognition.

[jonalmeida]

Left an offline comment to this discuss this since the permission was removed from the change and no longer a concern for this PR.

[hneiva]

No RelEng items, removing review request

[Mugurell]

LGTM!
Seeing all previous comments were addressed I'll also give this a r+ but we should check with Jonathan for any other updates to be made before merging.

[jonalmeida]

@iorgamgabriel it's not clear to me from the docs why the component or the apps need to have this permission. Could you share a link to where this requirement is?

[jonalmeida]

Why do we create this result launcher in onCreate to only use it later on in the same callback method?

Also, you use the @VisibleForTesting, but I don't see any tests that use it.

[iorgamgabriel]

Done

[jonalmeida]

It's still unclear to me why we need to hold this in a var in this fashion. :)

[jonalmeida]

This looks good to me to land (after the logger lint is fixed). Great work! 🎉

Please make sure the land as a single change so we can squash the commits that land on main into one.