This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Issue #11654: Change fetchProvidedTopSites into TopSitesProviderConfig #11668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielluong
added
the
work in progress
gabrielluong
force-pushed
the
11654
branch
2 times, most recently
from
c7f948e to
88e6e1f
Compare
|
This is looking good! |
gabrielluong
force-pushed
the
11654
branch
2 times, most recently
from
40f7b96 to
7438b5a
Compare
gabrielluong
changed the title
gabrielluong
force-pushed
the
11654
branch
3 times, most recently
from
663a7ad to
3c90898
Compare
…sProviderConfig This changes `fetchProvidedTopSites` into a data class `TopSitesProviderConfig` that specifies whether or not to display the top sites from the provider and the maximum threshold at which to fetch the top sites from the provider.
gabrielluong
removed
the
work in progress
gabrielluong
requested review from
Amejia481 and
MozillaNoah
and removed request for
grigoryk
Amejia481
reviewed
Feb 9, 2022
...ents/feature/top-sites/src/main/java/mozilla/components/feature/top/sites/TopSitesStorage.kt
Show resolved
Hide resolved
Amejia481
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Looks good in overall, just one question https://github.com/mozilla-mobile/android-components/pull/11668/files#r802739946
gabrielluong
added
🛬 needs landing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11654
This changes
fetchProvidedTopSitesinto a data classTopSitesProviderConfigthat specifieswhether or not to display the top sites from the provider and the maximum threshold at which to
fetch the top sites from the provider.
Pull Request checklist
After merge