Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #11360: Strip non-digit characters when calling getCreditCardIIN #11361

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Dec 3, 2021

Fixes #11360

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Dec 3, 2021
@Amejia481 Amejia481 requested a review from a team as a code owner December 3, 2021 20:11
@Amejia481 Amejia481 changed the title For #11360: Fix crash when saving credit cards Closes #11360: Strip non-digit characters when calling getCreditCardIIN Dec 3, 2021
@Amejia481 Amejia481 added the 🛬 needs landing PRs that are ready to land label Dec 3, 2021
@mergify mergify bot merged commit 09eb7d1 into mozilla-mobile:main Dec 3, 2021
@pocmo
Copy link
Contributor

pocmo commented Dec 6, 2021

Just a drive-by nit: We have been adding extension functions to support-ktx and everything else, that is more complex, to support-utils. At one point I was hopeful that all utilities in support-utils could be extension functions (and that component would disappear), but I am not sure if that will happen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land 🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreditCardUtils: NumberFormatException: For input string: "[..]"
3 participants