This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Issue #10205: Add support for select credit card prompt #10213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10213 +/- ##
============================================
+ Coverage 73.99% 76.34% +2.35%
+ Complexity 6227 4794 -1433
============================================
Files 833 592 -241
Lines 31694 23078 -8616
Branches 5265 3836 -1429
============================================
- Hits 23452 17620 -5832
+ Misses 5549 3407 -2142
+ Partials 2693 2051 -642
Continue to review full report at Codecov.
|
gabrielluong
force-pushed
the
10205
branch
4 times, most recently
from
bce8174 to
4605d37
Compare
4 tasks
|
This pull request has conflicts when rebasing. Could you fix it @gabrielluong? 🙏 |
gabrielluong
force-pushed
the
10205
branch
5 times, most recently
from
95219e0 to
9316743
Compare
Amejia481
reviewed
May 10, 2021
| */ | ||
| @Parcelize | ||
| data class CreditCard( | ||
| val guid: String?, |
There was a problem hiding this comment.
It seems a bit strange to have an identifier that can be null? Would you mind helping me to clarify this part?
There was a problem hiding this comment.
This is because of GV's Credit Card guid can be nullable. https://mozilla.github.io/geckoview/javadoc/mozilla-central/org/mozilla/geckoview/Autocomplete.CreditCard.html#guid
There was a problem hiding this comment.
That seems odd. Maybe there is a mistake in the API? The other fields are non-null, so a GUID should also be non-null.
Amejia481
reviewed
May 10, 2021
...nents/concept/engine/src/main/java/mozilla/components/concept/engine/prompt/PromptRequest.kt
Outdated
Show resolved
Hide resolved
Amejia481
reviewed
May 10, 2021
...s/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt
Outdated
Show resolved
Hide resolved
Amejia481
approved these changes
May 10, 2021
- Implements an override function of `onCreditCardSelect` in `GeckoPromptDelegate` - Adds a new `CreditCard` data class in `concept-engine`. This is a parallel of GV's `Autocomplete.CreditCard`. We can't using the existing `CreditCard` from `concept-storage` since that has encryption dependencies whereas the card number is already decrypted when it reaches GV. - Adds a new `SelectCreditCard` in `PromptRequest`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10205
onCreditCardSelectinGeckoPromptDelegateCreditCarddata class inconcept-engine. This is a parallel of GV'sAutocomplete.CreditCard. We can't using the existingCreditCardfromconcept-storagesince that has encryption dependencies whereas the card number is already decrypted
when it reaches GV.
SelectCreditCardPromptinPromptRequestPull Request checklist
After merge