This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add a sticky footer RecyclerView #9932
Assignees
Milestone
Comments
Mugurell
changed the title
|
Asking UX if we should use a sticky header/footer for all browser menus. |
|
Asking @topotropic and also @channingcarter how important showing the navigation buttons bar is and if we want it displayed in all cases. (with rest of the menu items scrollable but this always fixed in place and visible). |
14 tasks
|
Confirmed with @topotropic and @channingcarter that this should definitely be done now 👍 |
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 12, 2021
…eader / footer Vertical LinearLayoutManager configured with StickyItemPlacement such that: - if StickyItemPlacement.TOP the sticky item will not be scrolled upwards off-screen - if StickyItemPlacement.TOP the sticky item will not be scrolled downwards off-screen
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 12, 2021
Most of the menu items should support this new property and allow AC clients to configure the menus such that a specific menu item will not be scrolled off-screen but rather anchored to the top/bottom of the menu following where the menu is anchored.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 12, 2021
…pter The most important new responsibilities are to update the view of the sticky item. BrowserMenu's background is only set on the parent's layout so the Adapter will have to set that same background to the sticky item's view such that other items scrolling underneath it will be totally obscured. Because the menu's background can be set in multiple ways (by setting a value for mozac_browser_menu_background / by passing a MenuStyle or like in Fenix having a default theme for all "above" views) BrowserMenu will offer a new backgroundColor property that as the single source of truth for this which can then be used by the Adapter.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 12, 2021
If the menu starts as collapsed and it has a sticky footer set the bottom item until which the menu should be collapsed must be shown on top of the sticky item's view. For this the entire menu has to have as offset the height of the sticky item's view.
This was referenced Apr 12, 2021
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 14, 2021
…eader / footer Vertical LinearLayoutManager configured with StickyItemPlacement such that: - if StickyItemPlacement.TOP the sticky item will not be scrolled upwards off-screen - if StickyItemPlacement.TOP the sticky item will not be scrolled downwards off-screen
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 14, 2021
Most of the menu items should support this new property and allow AC clients to configure the menus such that a specific menu item will not be scrolled off-screen but rather anchored to the top/bottom of the menu following where the menu is anchored.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 14, 2021
…pter The most important new responsibilities are to update the view of the sticky item. BrowserMenu's background is only set on the parent's layout so the Adapter will have to set that same background to the sticky item's view such that other items scrolling underneath it will be totally obscured. Because the menu's background can be set in multiple ways (by setting a value for mozac_browser_menu_background / by passing a MenuStyle or like in Fenix having a default theme for all "above" views) BrowserMenu will offer a new backgroundColor property that as the single source of truth for this which can then be used by the Adapter.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 14, 2021
…ooter item index If the menu starts as collapsed and it has a sticky footer set the bottom item until which the menu should be collapsed must be shown on top of the sticky item's view. As an edgecase, if the same item is the limit of the collapsed menu and also the sticky footer that will be the last item shown in the collapsed menu but will be shown with full height.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 14, 2021
…pter The most important new responsibilities are to update the view of the sticky item. BrowserMenu's background is only set on the parent's layout so the Adapter will have to set that same background to the sticky item's view such that other items scrolling underneath it will be totally obscured. Because the menu's background can be set in multiple ways (by setting a value for mozac_browser_menu_background / by passing a MenuStyle or like in Fenix having a default theme for all "above" views) BrowserMenu will offer a new backgroundColor property that as the single source of truth for this which can then be used by the Adapter.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 14, 2021
…ooter item index If the menu starts as collapsed and it has a sticky footer set the bottom item until which the menu should be collapsed must be shown on top of the sticky item's view. As an edgecase, if the same item is the limit of the collapsed menu and also the sticky footer that will be the last item shown in the collapsed menu but will be shown with full height.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 14, 2021
…eader / footer Vertical LinearLayoutManager configured with StickyItemPlacement such that: - if StickyItemPlacement.TOP the sticky item will not be scrolled upwards off-screen - if StickyItemPlacement.TOP the sticky item will not be scrolled downwards off-screen
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 14, 2021
Most of the menu items should support this new property and allow AC clients to configure the menus such that a specific menu item will not be scrolled off-screen but rather anchored to the top/bottom of the menu following where the menu is anchored.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 14, 2021
…pter The most important new responsibilities are to update the view of the sticky item. BrowserMenu's background is only set on the parent's layout so the Adapter will have to set that same background to the sticky item's view such that other items scrolling underneath it will be totally obscured. Because the menu's background can be set in multiple ways (by setting a value for mozac_browser_menu_background / by passing a MenuStyle or like in Fenix having a default theme for all "above" views) BrowserMenu will offer a new backgroundColor property that as the single source of truth for this which can then be used by the Adapter.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Apr 14, 2021
…ooter item index If the menu starts as collapsed and it has a sticky footer set the bottom item until which the menu should be collapsed must be shown on top of the sticky item's view. As an edgecase, if the same item is the limit of the collapsed menu and also the sticky footer that will be the last item shown in the collapsed menu but will be shown with full height.
mergify bot
pushed a commit
that referenced
this issue
Apr 14, 2021
Vertical LinearLayoutManager configured with StickyItemPlacement such that: - if StickyItemPlacement.TOP the sticky item will not be scrolled upwards off-screen - if StickyItemPlacement.TOP the sticky item will not be scrolled downwards off-screen
mergify bot
pushed a commit
that referenced
this issue
Apr 14, 2021
Most of the menu items should support this new property and allow AC clients to configure the menus such that a specific menu item will not be scrolled off-screen but rather anchored to the top/bottom of the menu following where the menu is anchored.
mergify bot
pushed a commit
that referenced
this issue
Apr 14, 2021
The most important new responsibilities are to update the view of the sticky item. BrowserMenu's background is only set on the parent's layout so the Adapter will have to set that same background to the sticky item's view such that other items scrolling underneath it will be totally obscured. Because the menu's background can be set in multiple ways (by setting a value for mozac_browser_menu_background / by passing a MenuStyle or like in Fenix having a default theme for all "above" views) BrowserMenu will offer a new backgroundColor property that as the single source of truth for this which can then be used by the Adapter.
mergify bot
pushed a commit
that referenced
this issue
Apr 14, 2021
If the menu starts as collapsed and it has a sticky footer set the bottom item until which the menu should be collapsed must be shown on top of the sticky item's view. As an edgecase, if the same item is the limit of the collapsed menu and also the sticky footer that will be the last item shown in the collapsed menu but will be shown with full height.
Merged
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Saw the need for this on Fenix - mozilla-mobile/fenix#17772 which intends to use a collapsed menu with not all items shown on the screen. The list of items may be so big that even if the menu fits the screen not all items would be shown.
navigationButtonsNotSticky.mp4
From that ticket I understand there is a need to always show the list of navigation buttons
so we need a RecyclerView with sticky footers support and a property added to each BrowserMenuItem to indicate that that item should be a sticky footer.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: