Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

prompt.Choice[] cannot be cast to prompt.Choice #6687

Closed
st3fan opened this issue Apr 16, 2020 · 3 comments
Closed

prompt.Choice[] cannot be cast to prompt.Choice #6687

st3fan opened this issue Apr 16, 2020 · 3 comments
Assignees
@rocketsroger
Labels
blocked Blocked pull requests and issues 💥 crash E3 Estimation points: 3 <prompts> Component: feature-prompts

Comments

@st3fan
Copy link
Contributor

st3fan commented Apr 16, 2020 •
edited by data-sync-user
Loading

https://sentry.prod.mozaws.net/operations/firefox-beta/issues/7843411

java.lang.ClassCastException: mozilla.components.concept.engine.prompt.Choice[] cannot be cast to mozilla.components.concept.engine.prompt.Choice
    at mozilla.components.feature.prompts.PromptFeature.onConfirm(PromptFeature.kt:25)
    at -$$LambdaGroup$js$CAs0Y7NWl2_rHUSA2p5MNFfDxg0.onClick(java-style lambda group:3)
    at androidx.appcompat.app.AlertController$ButtonHandler.handleMessage(AlertController.java:3)
    at android.os.Handler.dispatchMessage(Handler.java:102)
    at android.os.Looper.loop(Looper.java:154)
    at android.app.ActivityThread.main(ActivityThread.java:6316)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:872)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:762)

┆Issue is synchronized with this Jira Task
@st3fan st3fan added <prompts> Component: feature-prompts 💥 crash labels Apr 16, 2020
@rocketsroger rocketsroger self-assigned this May 11, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue May 15, 2020
@rocketsroger
For mozilla-mobile#6687: Add crash reporting information for ClassCas…
3fbbfd8 
…tException in PromptFeature
rocketsroger added a commit to rocketsroger/android-components that referenced this issue May 15, 2020
@rocketsroger
For mozilla-mobile#6687: Add crash reporting information for ClassCas…
1dc8675 
…tException in PromptFeature
@rocketsroger
Copy link
Contributor

Looks like the frequency of this is very low. However, there are also other similar cases with very low frequency as well. I'll catch the exception and send a crash reporting with breadcrumb. Once we have the breadcrumb we can figure out which case is causing the crash.

@rocketsroger rocketsroger added the E3 Estimation points: 3 label May 19, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue May 19, 2020
@rocketsroger
For mozilla-mobile#6687: Add crash reporting information for ClassCas…
45c17f8 
…tException in PromptFeature
rocketsroger added a commit to rocketsroger/android-components that referenced this issue May 22, 2020
@rocketsroger
For mozilla-mobile#6687: Add crash reporting information for ClassCas…
01b9aac 
…tException in PromptFeature
rocketsroger added a commit to rocketsroger/android-components that referenced this issue May 25, 2020
@rocketsroger
For mozilla-mobile#6687: Add crash reporting information for ClassCas…
9fd251c 
…tException in PromptFeature
bors bot pushed a commit that referenced this issue May 25, 2020
@MozLando @rocketsroger
Merge #6995
f32794f 
6995: For #6687: Add crash reporting information for ClassCastException in PromptFeature r=pocmo a=rocketsroger



Co-authored-by: Roger Yang <[email protected]>
@rocketsroger
Copy link
Contributor

I'll continue to monitor this for a week to see if the patch works. If it works, I'll use the information to find the root cause.

@rocketsroger rocketsroger added the blocked Blocked pull requests and issues label May 25, 2020
@kbrosnan
Copy link
Contributor

Looks like this is fixed. Not seeing any crashes on 78 or 79.

Mugurell added a commit to Mugurell/android-components that referenced this issue May 18, 2021
@Mugurell
For mozilla-mobile#8989 - Don't catch rethrow prompt cast exceptions
fa52561 
This try-catch was added in mozilla-mobile#6687 as an effort to better individualize prompt
cast exceptions in our crash reporting platforms to better asses their
frequency and hopefully get more data to debug and fix the underlying issue.

The original issue is resolved in the first commit of this patch so there is no
need to keep the try-catch.
Mugurell added a commit to Mugurell/android-components that referenced this issue May 18, 2021
@Mugurell
For mozilla-mobile#8989 - Don't catch rethrow prompt cast exceptions
749cd8b 
This try-catch was added in mozilla-mobile#6687 as an effort to better individualize prompt
cast exceptions in our crash reporting platforms to better asses their
frequency and hopefully get more data to debug and fix the underlying issue.

The original issue is resolved in the first commit of this patch so there is no
need to keep the try-catch.
Mugurell added a commit to Mugurell/android-components that referenced this issue May 18, 2021
@Mugurell
For mozilla-mobile#8989 - Don't catch/rethrow prompt cast exceptions
a13b284 
This try-catch was added in mozilla-mobile#6687 as an effort to better individualize prompt
cast exceptions in our crash reporting platforms to better asses their
frequency and hopefully get more data to debug and fix the underlying issue.

The original issue is resolved in the first commit of this patch so there is no
need to keep the try-catch.
Mugurell added a commit to Mugurell/android-components that referenced this issue May 24, 2021
@Mugurell
For mozilla-mobile#8989 - Don't catch/rethrow prompt cast exceptions
9eb6c97 
This try-catch was added in mozilla-mobile#6687 as an effort to better individualize prompt
cast exceptions in our crash reporting platforms to better asses their
frequency and hopefully get more data to debug and fix the underlying issue.

The original issue is resolved in the first commit of this patch so there is no
need to keep the try-catch.
Mugurell added a commit to Mugurell/android-components that referenced this issue May 26, 2021
@Mugurell
For mozilla-mobile#8989 - Don't catch/rethrow prompt cast exceptions
29831a1 
This try-catch was added in mozilla-mobile#6687 as an effort to better individualize prompt
cast exceptions in our crash reporting platforms to better asses their
frequency and hopefully get more data to debug and fix the underlying issue.

The original issue is resolved in the first commit of this patch so there is no
need to keep the try-catch.
Mugurell added a commit to Mugurell/android-components that referenced this issue Jun 2, 2021
@Mugurell
For mozilla-mobile#8989 - Don't catch/rethrow prompt cast exceptions
168711f 
This try-catch was added in mozilla-mobile#6687 as an effort to better individualize prompt
cast exceptions in our crash reporting platforms to better asses their
frequency and hopefully get more data to debug and fix the underlying issue.

The original issue is resolved in the first commit of this patch so there is no
need to keep the try-catch.
mergify bot pushed a commit that referenced this issue Jun 2, 2021
@Mugurell @mergify
For #8989 - Don't catch/rethrow prompt cast exceptions
1a9b3ea 
This try-catch was added in #6687 as an effort to better individualize prompt
cast exceptions in our crash reporting platforms to better asses their
frequency and hopefully get more data to debug and fix the underlying issue.

The original issue is resolved in the first commit of this patch so there is no
need to keep the try-catch.
grigoryk pushed a commit to gabrielluong/android-components that referenced this issue Sep 11, 2021
@Mugurell
For mozilla-mobile#8989 - Don't catch/rethrow prompt cast exceptions
89c8523 
This try-catch was added in mozilla-mobile#6687 as an effort to better individualize prompt
cast exceptions in our crash reporting platforms to better asses their
frequency and hopefully get more data to debug and fix the underlying issue.

The original issue is resolved in the first commit of this patch so there is no
need to keep the try-catch.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

Labels
blocked Blocked pull requests and issues 💥 crash E3 Estimation points: 3 <prompts> Component: feature-prompts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@st3fan @kbrosnan @rocketsroger