Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Create a Top Sites Storage component #5315

Closed
gabrielluong opened this issue Dec 13, 2019 · 1 comment · Fixed by #5360
Closed

Create a Top Sites Storage component #5315

gabrielluong opened this issue Dec 13, 2019 · 1 comment · Fixed by #5360
Assignees

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Dec 13, 2019

This adds a new storage component using Room to save/remove top sites. Related storage discussions happened in mozilla/application-services#2163 (comment).

Fenix Meta fenix#6190
UX https://share.goabstract.com/f9ae2c95-4a95-4b0e-917c-d87b9854a600?mode=design&sha=2fac94ac7fd2676633043e1967dc696c5071a8da

┆Issue is synchronized with this Jira Task

@gabrielluong gabrielluong self-assigned this Dec 13, 2019
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Dec 18, 2019
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Dec 18, 2019
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Dec 18, 2019
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Dec 19, 2019
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Dec 19, 2019
bors bot pushed a commit that referenced this issue Dec 19, 2019
5360: Closes #5315 - Create a Top Sites storage component r=pocmo a=gabrielluong



Co-authored-by: Gabriel Luong <[email protected]>
bors bot pushed a commit that referenced this issue Dec 19, 2019
5360: Closes #5315 - Create a Top Sites storage component r=pocmo a=gabrielluong



Co-authored-by: Gabriel Luong <[email protected]>
@gabrielluong
Copy link
Member Author

This is a blocker to mozilla-mobile/fenix#6758

bors bot pushed a commit that referenced this issue Dec 19, 2019
5285: Closes #5284: Adds progress bar to download notification r=pocmo a=sblatz



5294: Closes #4556: Passwords sync telemetry support r=rocketsroger,liuche a=grigoryk

This adds a new ping to `support-telemetry-sync` - passwords_sync, which is then used in `services-firefox-accounts` and in `service-sync-logins` to emit password sync telemetry whenever this engine is synchronized. New ping is a verbatim copy of the history_sync ping.

`samples-sync` app was also updated to demonstrate to how synchronize passwords, and how to protect encryption key at rest used for the password storage.



5360: Closes #5315 - Create a Top Sites storage component r=pocmo a=gabrielluong



Co-authored-by: Sawyer Blatz <[email protected]>
Co-authored-by: Grisha Kruglov <[email protected]>
Co-authored-by: Gabriel Luong <[email protected]>
bors bot pushed a commit that referenced this issue Dec 19, 2019
5294: Closes #4556: Passwords sync telemetry support r=rocketsroger,liuche a=grigoryk

This adds a new ping to `support-telemetry-sync` - passwords_sync, which is then used in `services-firefox-accounts` and in `service-sync-logins` to emit password sync telemetry whenever this engine is synchronized. New ping is a verbatim copy of the history_sync ping.

`samples-sync` app was also updated to demonstrate to how synchronize passwords, and how to protect encryption key at rest used for the password storage.



5360: Closes #5315 - Create a Top Sites storage component r=pocmo a=gabrielluong



Co-authored-by: Grisha Kruglov <[email protected]>
Co-authored-by: Gabriel Luong <[email protected]>
@bors bors bot closed this as completed in ee1c068 Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant