Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Configure LongMethod rule to be less strict. #4004

Closed
pocmo opened this issue Aug 2, 2019 · 0 comments
Closed

Configure LongMethod rule to be less strict. #4004

pocmo opened this issue Aug 2, 2019 · 0 comments
Labels
⌨️ code Technical debt, code clean up, small API change .. 🔧 tooling Tooling for debugging and developing components

Comments

@pocmo
Copy link
Contributor

pocmo commented Aug 2, 2019 •
edited by data-sync-user
Loading

The default is 60:
https://github.com/arturbosch/detekt/blob/f98ccac9aa352805621dd6a19888bb472d776cef/detekt-rules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/LongMethod.kt#L24

We somehow use 20:
https://github.com/mozilla-mobile/android-components/blob/master/config/detekt.yml#L91

We hit that quite often and it feels wrong quite often. Let's raise it to something higher - up to 60. Also let's try to get rid of the @Supress("LongMethod") code that doesn't need that anymore.

┆Issue is synchronized with this Jira Task
@pocmo pocmo added ⌨️ code Technical debt, code clean up, small API change .. 🔧 tooling Tooling for debugging and developing components labels Aug 2, 2019
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 2, 2019
@NotWoods
Closes mozilla-mobile#4004 - Increase limit for LongMethod rule
b219046
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
⌨️ code Technical debt, code clean up, small API change .. 🔧 tooling Tooling for debugging and developing components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pocmo