Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Show broken padlock on all HTTP sites #3647

Closed
NotWoods opened this issue Jul 4, 2019 · 2 comments
Closed

Show broken padlock on all HTTP sites #3647

NotWoods opened this issue Jul 4, 2019 · 2 comments
Labels
<engine-gecko> Component: browser-engine-gecko 🌟 feature New functionality and improvements <toolbar> Components: browser-toolbar, concept-toolbar
Milestone
9.0.0 📷

Comments

@NotWoods
Copy link
Contributor

NotWoods commented Jul 4, 2019 •
edited by data-sync-user
Loading

Originally filed by @Madis0:

Why/User Benefit/User Problem

Users should be made aware that HTTP connections are not "normal", but unsecured.
The desktop Firefox does it by showing a broken padlock on the address bar of HTTP sites.

It also has several relevant about:config options for enabling additional warnings, such as "Not secure" text and icon change on all or private windows. Current Fennec and Fenix lack all of that, placing users at a risk.

What/Requirements

Implement the following about:config options from desktop Firefox:

  • security.insecure_connection_icon.enabled
  • security.insecure_connection_icon.pbmode.enabled
  • security.insecure_field_warning.contextual.enabled
  • security.insecure_password.ui.enabled

Acceptance Criteria (how do I know when I’m done?)

  • Default-enabled warnings on password fields
  • Config options for private tabs
  • Config options for all tabs

GeckoView bug: Bug 1563431

┆Issue is synchronized with this Jira Task
@NotWoods NotWoods added <toolbar> Components: browser-toolbar, concept-toolbar needs:gv To implement/fix this we need a new API in GeckoView labels Jul 4, 2019
@NotWoods NotWoods mentioned this issue Jul 4, 2019
Closed
3 tasks
@pocmo pocmo added <engine-gecko> Component: browser-engine-gecko 🌟 feature New functionality and improvements labels Jul 4, 2019
@Madis0
Copy link

Madis0 commented Jul 15, 2019 •
edited
Loading

Fenix still needs a default-enabled flag to mark all HTTP insecure as well, as that will be the default in desktop Firefox soon - bug 1562881 (see D37790).

NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 2, 2019
@NotWoods
Issue mozilla-mobile#3647 - Custom HTTP(S) icons in toolbar
44bf9a0
@NotWoods NotWoods changed the title Show broken padlock on HTTP site with password fields Show broken padlock on all HTTP sites Aug 2, 2019
@NotWoods NotWoods removed the needs:gv To implement/fix this we need a new API in GeckoView label Aug 2, 2019
@NotWoods
Copy link
Contributor Author

NotWoods commented Aug 2, 2019

Changing this issue to affect all HTTP sites since desktop firefox shows the broken padlock for all.

NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 2, 2019
@NotWoods
Issue mozilla-mobile#3647 - Custom HTTP(S) icons in toolbar
eee6e6b
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 7, 2019
@NotWoods
Issue mozilla-mobile#3647 - Custom HTTP(S) icons in toolbar
02fb0aa
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 7, 2019
@NotWoods
Issue mozilla-mobile#3647 - Custom HTTP(S) icons in toolbar
d2545f5
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 7, 2019
@NotWoods
Issue mozilla-mobile#3647 - Custom HTTP(S) icons in toolbar
2068619
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 8, 2019
@NotWoods
Issue mozilla-mobile#3647 - Custom HTTP(S) icons in toolbar
bfd6e1a
NotWoods added a commit that referenced this issue Aug 8, 2019
@NotWoods
Issue #3647 - Custom HTTP(S) icons in toolbar
c257ffb
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 12, 2019
@NotWoods
Issue mozilla-mobile#3647 - Bring back siteSecurityColor
57c2244
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 12, 2019
@NotWoods
Issue mozilla-mobile#3647 - Bring back siteSecurityColor
db35d94
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 12, 2019
@NotWoods
Issue mozilla-mobile#3647 - Bring back siteSecurityColor
d94edf9
NotWoods added a commit that referenced this issue Aug 12, 2019
@NotWoods
Issue #3647 - Bring back siteSecurityColor
5f3be2b
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 14, 2019
@NotWoods
Issue mozilla-mobile#3647 - Add broken lock icon
b4029c1
bors bot pushed a commit that referenced this issue Aug 14, 2019
@MickeyMoz @NotWoods
Merge #4126
3a740b0 
4126: Issue #3647 - Add broken lock icon r=jonalmeida a=NotWoods



Co-authored-by: Tiger Oakes <[email protected]>
bors bot pushed a commit that referenced this issue Aug 14, 2019
@MickeyMoz @NotWoods
Merge #4127
8bfb009 
4127: Closes #3647 - Change HTTP icon to broken lock r=pocmo a=NotWoods

All HTTP sites are now marked insecure by default.



Co-authored-by: Tiger Oakes <[email protected]>
bors bot pushed a commit that referenced this issue Aug 14, 2019
@MickeyMoz @NotWoods
Merge #4127
0c766d2 
4127: Closes #3647 - Change HTTP icon to broken lock r=pocmo a=NotWoods

All HTTP sites are now marked insecure by default.



Co-authored-by: Tiger Oakes <[email protected]>
@bors bors bot closed this as completed in d0d581d Aug 14, 2019
@NotWoods NotWoods added this to the 9.0.0 📷 milestone Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
<engine-gecko> Component: browser-engine-gecko 🌟 feature New functionality and improvements <toolbar> Components: browser-toolbar, concept-toolbar
Projects
None yet
Milestone
9.0.0 📷
Development

No branches or pull requests
3 participants
@pocmo @NotWoods @Madis0