This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
MozillaSocorroService: Inline upload functionality #2203
Assignees
Labels
Milestone
Comments
pocmo
added
🌟 feature
|
I once tried that but it turned out to be more code than expected. It's still doable but was too much to do it as a quick win. |
rocketsroger
added a commit
to rocketsroger/android-components
that referenced
this issue
Sep 28, 2019
…d functionality and add support for "uncaught exception" crash reports
rocketsroger
added a commit
to rocketsroger/android-components
that referenced
this issue
Sep 30, 2019
…d functionality and add support for "uncaught exception" crash reports
rocketsroger
added a commit
to rocketsroger/android-components
that referenced
this issue
Oct 1, 2019
…d functionality and add support for "uncaught exception" crash reports
rocketsroger
added a commit
to rocketsroger/android-components
that referenced
this issue
Oct 2, 2019
…d functionality and add support for "uncaught exception" crash reports
bors bot
pushed a commit
that referenced
this issue
Oct 2, 2019
4555: Closes #4535: Integrate setEnhancedTrackingProtectionLevel geckoView api. r=csadilek a=Amejia481 4572: Closes #2203, #3511: Inline Socorro upload functionality and add supp… r=pocmo a=rocketsroger …ort for "uncaught exception" crash reports Co-authored-by: Arturo Mejia <[email protected]> Co-authored-by: Roger Yang <[email protected]>
rocketsroger
added a commit
to rocketsroger/android-components
that referenced
this issue
Oct 3, 2019
…d functionality and add support for "uncaught exception" crash reports
bors bot
pushed a commit
that referenced
this issue
Oct 3, 2019
3918: Closes #3791 - Derive app icon for likely app-link app r=jonalmeida a=jhugman This PR exposes the icon and name of the app used to open a given link. This is to allow Fenix to display the app icon in the Quick Action Bar `Open in App` action. ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [X] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [X] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one - ~[ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features~ ### After merge - [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development. 4572: Closes #2203, #3511: Inline Socorro upload functionality and add supp… r=pocmo a=rocketsroger …ort for "uncaught exception" crash reports 4617: Fix Glean SDK specific metrics API to be callable from Java r=Dexterp37 a=Dexterp37 This adds `@JvmOverloads` to the specific metrics API and the testing API. 4621: Docs update (20191003-121147) [ci skip] r=jonalmeida a=MickeyMoz Co-authored-by: James Hugman <[email protected]> Co-authored-by: Jonathan Almeida <[email protected]> Co-authored-by: Roger Yang <[email protected]> Co-authored-by: Alessio Placitelli <[email protected]> Co-authored-by: MickeyMoz <[email protected]>
bors bot
pushed a commit
that referenced
this issue
Oct 3, 2019
3918: Closes #3791 - Derive app icon for likely app-link app r=jonalmeida a=jhugman This PR exposes the icon and name of the app used to open a given link. This is to allow Fenix to display the app icon in the Quick Action Bar `Open in App` action. ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [X] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [X] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one - ~[ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features~ ### After merge - [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development. 4572: Closes #2203, #3511: Inline Socorro upload functionality and add supp… r=pocmo a=rocketsroger …ort for "uncaught exception" crash reports Co-authored-by: James Hugman <[email protected]> Co-authored-by: Jonathan Almeida <[email protected]> Co-authored-by: Roger Yang <[email protected]>
rocketsroger
added a commit
to rocketsroger/android-components
that referenced
this issue
Oct 3, 2019
…o upload functionality and add support for "uncaught exception" crash reports
bors bot
pushed a commit
that referenced
this issue
Oct 3, 2019
3918: Closes #3791 - Derive app icon for likely app-link app r=jonalmeida a=jhugman This PR exposes the icon and name of the app used to open a given link. This is to allow Fenix to display the app icon in the Quick Action Bar `Open in App` action. ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [X] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [X] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one - ~[ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features~ ### After merge - [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development. 4572: Closes #2203, #3511: Inline Socorro upload functionality and add supp… r=pocmo a=rocketsroger …ort for "uncaught exception" crash reports Co-authored-by: James Hugman <[email protected]> Co-authored-by: Jonathan Almeida <[email protected]> Co-authored-by: Roger Yang <[email protected]>
rocketsroger
added a commit
to rocketsroger/android-components
that referenced
this issue
Oct 4, 2019
…o upload functionality and add support for "uncaught exception" crash reports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We ran into an issue with the upload caused by incompatible APIs:
https://bugzilla.mozilla.org/show_bug.cgi?id=1530757#c2
lib-crashhas acompileOnlydependency onGeckoViewto allow us callingGeckoCrashReporter.sendCrashReport(). If there's an API change causing incompatibility this just blows up. Sincelib-crashcannot depend on an actual GeckoView version (it should work with all of them after all) we should bite the bullet and inline the code fromsendCrashReportand remove thecompileOnlydependency.┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: