Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Expose state: "Is this page viewable in reader view?" #1385

Closed
pocmo opened this issue Nov 15, 2018 · 2 comments · Fixed by #2861
Closed

Expose state: "Is this page viewable in reader view?" #1385

pocmo opened this issue Nov 15, 2018 · 2 comments · Fixed by #2861
Assignees
@csadilek
Labels
<engine-gecko> Component: browser-engine-gecko 🌟 feature New functionality and improvements 🐉 Fenix Feature needed for Fenix P1 🌐 reference browser Features, bugs, issues related to the reference browser implementation <session> Component: browser-session
Milestone
0.51.0 🍜

Comments

@pocmo
Copy link
Contributor

pocmo commented Nov 15, 2018 •
edited by data-sync-user
Loading

Issue #1346 is about showing a page in reader view. However not all pages can be watched in reader view. The engine would need to tell us and we would need to forward that information through the Session to the UI.

┆Issue is synchronized with this Jira Task
@pocmo pocmo added 🌟 feature New functionality and improvements <session> Component: browser-session <engine-gecko> Component: browser-engine-gecko needs:gv To implement/fix this we need a new API in GeckoView labels Nov 15, 2018
@pocmo pocmo mentioned this issue Nov 15, 2018
Closed
@st3fan st3fan mentioned this issue Nov 15, 2018
Closed
3 tasks
@pocmo pocmo added 🌐 reference browser Features, bugs, issues related to the reference browser implementation S labels Nov 15, 2018
@pocmo
Copy link
Contributor Author

pocmo commented Nov 22, 2018

https://bugzilla.mozilla.org/show_bug.cgi?id=1509258

@pocmo pocmo mentioned this issue Feb 11, 2019
Closed
@vesta0 vesta0 added the P1 label Mar 4, 2019
@csadilek csadilek added the blocked Blocked pull requests and issues label Mar 4, 2019
@csadilek
Copy link
Contributor

csadilek commented Mar 4, 2019

The plan is to implement this using the generic messaging API: #2243

@vesta0 vesta0 mentioned this issue Mar 8, 2019
Closed
@csadilek csadilek self-assigned this Apr 1, 2019
@csadilek csadilek added the 🐉 Fenix Feature needed for Fenix label Apr 5, 2019
@csadilek csadilek removed blocked Blocked pull requests and issues needs:gv To implement/fix this we need a new API in GeckoView labels Apr 22, 2019
csadilek added a commit to csadilek/android-components that referenced this issue Apr 26, 2019
@csadilek
Closes mozilla-mobile#1385: Determine and expose reader-ability state
ba449b4
csadilek added a commit to csadilek/android-components that referenced this issue Apr 26, 2019
@csadilek
Closes mozilla-mobile#1385: Determine and expose reader-ability state
dfa3d50
csadilek added a commit to csadilek/android-components that referenced this issue Apr 26, 2019
@csadilek
Closes mozilla-mobile#1385: Determine and expose reader-ability state
1e8332f
@csadilek csadilek added this to the 0.51.0 🍜 milestone Apr 26, 2019
csadilek added a commit to csadilek/android-components that referenced this issue Apr 26, 2019
@csadilek
Closes mozilla-mobile#1385: Determine and expose reader-ability state
0984d49
csadilek added a commit to csadilek/android-components that referenced this issue Apr 26, 2019
@csadilek
Closes mozilla-mobile#1385: Determine and expose reader-ability state
0747fde
@csadilek csadilek mentioned this issue Apr 26, 2019
Merged
csadilek added a commit to csadilek/android-components that referenced this issue Apr 26, 2019
@csadilek
Closes mozilla-mobile#1385: Determine and expose reader-ability state
56a2987
csadilek added a commit that referenced this issue Apr 26, 2019
@csadilek
Closes #1385: Determine and expose reader-ability state
671f998
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@csadilek csadilek

Labels
<engine-gecko> Component: browser-engine-gecko 🌟 feature New functionality and improvements 🐉 Fenix Feature needed for Fenix P1 🌐 reference browser Features, bugs, issues related to the reference browser implementation <session> Component: browser-session
Projects
None yet
Milestone
0.51.0 🍜
Development

Successfully merging a pull request may close this issue.

Closes #1385: Determine and expose reader-ability state csadilek/android-components
3 participants
@pocmo @csadilek @vesta0