Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Cannot click items on the expanded browser menu on Samsung devices #10032

Closed
Mugurell opened this issue Apr 6, 2021 · 0 comments · Fixed by #10033
Closed

Cannot click items on the expanded browser menu on Samsung devices #10032

Mugurell opened this issue Apr 6, 2021 · 0 comments · Fixed by #10033
Assignees

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Apr 6, 2021

Seen by @lobontiumira on Fenix - mozilla-mobile/fenix#18814

After expanding an initially collapsed menu it cannot be interacted with.

Debugging on a Samsung S9 with Android 10 I saw that even though the touchSlop is not smaller on Samsung devices when compared to others a simple tap will actually send a MotionEvent.ACTION_MOVE based on which this code that should have just guard against unintended scrolls while the menu is expanding will swallow the touch.

┆Issue is synchronized with this Jira Task

@Mugurell Mugurell self-assigned this Apr 6, 2021
Mugurell added a commit to Mugurell/android-components that referenced this issue Apr 6, 2021
…Samsung devices

Refactored the code so that touches/scrolls are still swallowed while the
menu is expanding after which ExpandableLayout should let all MotionEvents
pass through to be handled by menu items children.
Mugurell added a commit to Mugurell/android-components that referenced this issue Apr 6, 2021
…Samsung devices

Refactored the code so that touches/scrolls are still swallowed while the
menu is expanding after which ExpandableLayout should let all MotionEvents
pass through to be handled by menu items children.
@mergify mergify bot closed this as completed in #10033 Apr 12, 2021
mergify bot pushed a commit that referenced this issue Apr 12, 2021
Refactored the code so that touches/scrolls are still swallowed while the
menu is expanding after which ExpandableLayout should let all MotionEvents
pass through to be handled by menu items children.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant