Post: changelog; add a follow-up around persisting the state

mozilla-mobile · Nov 20, 2019 · 767cf4b · 767cf4b
1 parent f1753c3
commit 767cf4b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/...irefox-accounts/src/main/java/mozilla/components/service/fxa/manager/FxaAccountManager.kt b/...irefox-accounts/src/main/java/mozilla/components/service/fxa/manager/FxaAccountManager.kt
@@ -233,6 +233,10 @@ open class FxaAccountManager(
     // list, although that's probably an overkill.
     @Volatile private lateinit var account: OAuthAccount
     @Volatile private var profile: Profile? = null
+
+    // We'd like to persist this state, so that we can short-circuit transition to AuthenticationProblem on
+    // initialization, instead of triggering the full state machine knowing in advance we'll hit auth problems.
+    // See https://github.com/mozilla-mobile/android-components/issues/5102
     @Volatile private var state = AccountState.Start
     private val eventQueue = ConcurrentLinkedQueue<Event>()
 

diff --git a/docs/changelog.md b/docs/changelog.md
@@ -18,6 +18,10 @@ permalink: /changelog/
 * **feature-prompts** and **feature-downloads**
   * Fix [issue #6439](https://github.com/mozilla-mobile/fenix/issues/6439) "Crash when downloading Image"
 
+* **service-firefox-accounts**
+  * Account profile cache is now used, removing a network call from most instances of account manager instantiation.
+  * Fixed a bug where account would disappear after restarting an app which hit authentication problems.
+
 # 22.0.0
 
 * [Commits](https://github.com/mozilla-mobile/android-components/compare/v22.0.0...master)