Merge #5299

5299: For #5296 Improve a11y for error pages r=Amejia481 a=mcarare Use role="presentation" for `<ul>` to remove `<li>` semantics for screen reader. Remove `<p>` from errorShortDesc because paragraphs cannot contain lists. Co-authored-by: mcarare <[email protected]>
mozilla-mobile · Dec 19, 2019 · 54e790c · 54e790c
2 parents c4da824 + 15d6279
commit 54e790c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/...ents/browser/errorpages/src/main/java/mozilla/components/browser/errorpages/ErrorPages.kt b/...ents/browser/errorpages/src/main/java/mozilla/components/browser/errorpages/ErrorPages.kt
@@ -36,6 +36,7 @@ object ErrorPages {
             .replace("%button%", context.getString(errorType.refreshButtonRes))
             .replace("%messageShort%", context.getString(errorType.titleRes))
             .replace("%messageLong%", context.getString(errorType.messageRes, uri))
+            .replace("<ul>", "<ul role=\"presentation\">")
             .replace("%css%", css)
     }
 }

diff --git a/components/browser/errorpages/src/main/res/raw/error_pages.html b/components/browser/errorpages/src/main/res/raw/error_pages.html
@@ -5,8 +5,8 @@
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <html xmlns="http://www.w3.org/1999/xhtml">
-    <meta charset="UTF-8">
     <head>
+        <meta charset="UTF-8">
         <meta name="viewport" content="width=device-width; user-scalable=false;" />
         <title>%pageTitle%</title>
         <style>%css%</style>
@@ -26,7 +26,7 @@ <h1 id="et_dnsNotFound" class="errorTitleText">%messageShort%</h1>
 
                 <!-- Short Description -->
                 <div id="errorShortDesc">
-                    <p id="errorShortDescText">%messageLong%</p>
+                   %messageLong%
                 </div>
 
             </div>

diff --git a/docs/changelog.md b/docs/changelog.md
@@ -55,7 +55,10 @@ permalink: /changelog/
     * `FxaPushSupportFeature` is now needed for integrating Firefox Accounts with Push support.
 
 * **support-test-libstate**
-  * 🆕 New component providing utilities to test functionality that relies on lib-state.    
+  * 🆕 New component providing utilities to test functionality that relies on lib-state.
+
+* **browser-errorpages**
+  * Removed list items semantics to improve a11y for unordered lists, preventing items being read twice.
 
 * **support-locale**
     * Add `resetToSystemDefault` and `getSystemDefault` method to `LocaleManager`