-
Notifications
You must be signed in to change notification settings - Fork 46
Lockwise keychain launch issues #1192
Changes from 2 commits
e8b1ae8
06e5ada
94c21ff
f7f3f42
f34a466
7598a12
2cee759
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |
func application(_ application: UIApplication, willFinishLaunchingWithOptions | ||
launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool { | ||
if isFirstRun { | ||
KeychainWrapper.wipeKeychain() | ||
KeychainWrapper.sharedAppContainerKeychain.clearAllValues(for: .account) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IIUIC, we should be able to clear values for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed |
||
} else { | ||
checkForKeychainVersionAbnormalities() | ||
} | ||
|
@@ -107,7 +107,8 @@ extension AppDelegate { | |
} else if previous > current { | ||
//this would mean a user had an upgraded test version and has now downgraded to a previous version | ||
//we should wipe keychain data to remove any possible abnormalities | ||
KeychainWrapper.wipeKeychain() | ||
KeychainWrapper.sharedAppContainerKeychain.clearAllValues(for: .account) | ||
KeychainWrapper.sharedAppContainerKeychain.clearAllValues(for: .database) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In time, will we move back to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. I like being explicit about the values for now, but I think in the future we could do this. |
||
} | ||
} | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -142,7 +142,7 @@ extension AccountStore { | |
} | ||
|
||
private func clear() { | ||
KeychainWrapper.wipeKeychain() | ||
keychainWrapper.clearAllValues(for: .account) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IIUC This is the point which fixes the bug. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes 👍 |
||
|
||
self.webData.fetchDataRecords(ofTypes: WKWebsiteDataStore.allWebsiteDataTypes()) { records in | ||
self.webData.removeData(ofTypes: WKWebsiteDataStore.allWebsiteDataTypes(), for: records) { } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸