Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Use new Telemetry SDK (Glean) in iOS #1129

Closed
ddurst opened this issue Nov 13, 2019 · 1 comment
Closed

Use new Telemetry SDK (Glean) in iOS #1129

ddurst opened this issue Nov 13, 2019 · 1 comment
Assignees
@travis79
Labels
metrics metrics and telemetry related task Issue describes a task that needs to be completed but is not a defect or enhancement in itself.
Milestone
1.7.2

Comments

@ddurst
Copy link

ddurst commented Nov 13, 2019

Similar to mozilla-lockwise/lockwise-android#127, we want to migrate our existing telemetry implementation to use the new Telemetry SDK.
@ddurst ddurst added task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. metrics metrics and telemetry related labels Nov 13, 2019
travis79 added a commit to travis79/lockwise-ios that referenced this issue Nov 15, 2019
@travis79
Add basic Glean integration (mozilla-lockwise#1129)
31302bd 
This adds the basic Glean dependency to the Cartfile and initializes Glean in order to send the baseline ping.  This doesn't include any events or other metrics yet, those will be included in a subsequent commit.
travis79 added a commit to travis79/lockwise-ios that referenced this issue Nov 18, 2019
@travis79
Add basic Glean integration (mozilla-lockwise#1129)
fb070cc 
This adds the basic Glean dependency to the Cartfile and initializes Glean in order to send the baseline ping.  This doesn't include any events or other metrics yet, those will be included in a subsequent commit.
travis79 added a commit to travis79/lockwise-ios that referenced this issue Nov 19, 2019
@travis79
Add basic Glean integration (mozilla-lockwise#1129)
d5d7833 
This adds the basic Glean dependency to the Cartfile.

This also includes a minimal initialization for Glean and ties it to the telemetry preference in order to opt out.

This just activates the Glean baseline ping and doesn't include any events or other metrics yet, those will be included in a subsequent commit/PR.
travis79 added a commit to travis79/lockwise-ios that referenced this issue Nov 19, 2019
@travis79
Add basic Glean integration (mozilla-lockwise#1129)
c1bba93 
This adds the basic Glean dependency to the Cartfile.

This also includes a minimal initialization for Glean and ties it to the telemetry preference in order to opt out.

This just activates the Glean baseline ping and doesn't include any events or other metrics yet, those will be included in a subsequent commit/PR.
Use Glean v21.0.0
travis79 added a commit to travis79/lockwise-ios that referenced this issue Nov 19, 2019
@travis79
Add basic Glean integration (mozilla-lockwise#1129)
81d6302 
This adds the basic Glean dependency to the Cartfile.

This also includes a minimal initialization for Glean and ties it to the telemetry preference in order to opt out.

This just activates the Glean baseline ping and doesn't include any events or other metrics yet, those will be included in a subsequent commit/PR.

Use Glean v21.0.0

Update metrics.md
travis79 added a commit to travis79/lockwise-ios that referenced this issue Nov 21, 2019
@travis79
Add basic Glean integration (mozilla-lockwise#1129)
4931018 
This adds the basic Glean dependency to the Cartfile.

This also includes a minimal initialization for Glean and ties it to the telemetry preference in order to opt out.

This just activates the Glean baseline ping and doesn't include any events or other metrics yet, those will be included in a subsequent commit/PR.

Use Glean v21.0.0

Update metrics.md
travis79 added a commit to travis79/lockwise-ios that referenced this issue Nov 22, 2019
@travis79
Add basic Glean integration (mozilla-lockwise#1129)
2766a4e 
This includes the minimum initialization for Glean, which will only enable and emit the Glean baseline ping.  This is tied to the "Send Usage Data" preference in order for users to be able to opt-out of telemetry collection.

This PR also adds and sets up a `GleanActionHandler` observer of the `TelemetryActions`, even though it's not doing anything with those actions yet.  This is in preparation for migration of existing telemetry to Glean but the actual collection of events and other metrics will be included in a subsequent PR.

This updates metrics.md to add Glean collection and references.

**Note:** This is built using a Glean binary only Carthage dependency.  This will change to a binary attaced to a Glean GitHub release once the Glean CI is properly publishing binary builds to GitHub Releases.
@travis79
Copy link
Member

Data review request form filed in this bug

travis79 added a commit to travis79/lockwise-ios that referenced this issue Dec 2, 2019
@travis79
Add basic Glean integration (mozilla-lockwise#1129)
e4c08c3 
This includes the minimum initialization for Glean, which will only enable and emit the Glean baseline ping.  This is tied to the "Send Usage Data" preference in order for users to be able to opt-out of telemetry collection.

This PR also adds and sets up a `GleanActionHandler` observer of the `TelemetryActions`, even though it's not doing anything with those actions yet.  This is in preparation for migration of existing telemetry to Glean but the actual collection of events and other metrics will be included in a subsequent PR.

This updates metrics.md to add Glean collection and references.

**Note:** This is built using a Glean tagged release with binary labeled "v21.2.1-TESTING1".  This tag is pointing at a stable release build of Glean, the TESTING part is just because it's not an official release.
travis79 added a commit to travis79/lockwise-ios that referenced this issue Dec 4, 2019
@travis79
Add basic Glean integration (mozilla-lockwise#1129)
752a356 
This includes the minimum initialization for Glean, which will only enable and emit the Glean baseline ping.  This is tied to the "Send Usage Data" preference in order for users to be able to opt-out of telemetry collection.

This PR also adds and sets up a `GleanActionHandler` observer of the `TelemetryActions`, even though it's not doing anything with those actions yet.  This is in preparation for migration of existing telemetry to Glean but the actual collection of events and other metrics will be included in a subsequent PR.

Includes update to metrics.md to add Glean collection and references.
travis79 added a commit to travis79/lockwise-ios that referenced this issue Dec 6, 2019
@travis79
Add basic Glean integration (mozilla-lockwise#1129)
200f3c2 
This includes the minimum initialization for Glean, which will only enable and emit the Glean baseline ping.  This is tied to the "Send Usage Data" preference in order for users to be able to opt-out of telemetry collection.

This PR also adds and sets up a `GleanActionHandler` observer of the `TelemetryActions`, even though it's not doing anything with those actions yet.  This is in preparation for migration of existing telemetry to Glean but the actual collection of events and other metrics will be included in a subsequent PR.

Includes update to metrics.md to add Glean collection and references.
kaylagalway pushed a commit that referenced this issue Dec 6, 2019
@travis79 @kaylagalway
Add basic Glean integration (#1129) (#1139)
f483e5d 
* Add basic Glean integration (#1129)

This includes the minimum initialization for Glean, which will only enable and emit the Glean baseline ping.  This is tied to the "Send Usage Data" preference in order for users to be able to opt-out of telemetry collection.

This PR also adds and sets up a `GleanActionHandler` observer of the `TelemetryActions`, even though it's not doing anything with those actions yet.  This is in preparation for migration of existing telemetry to Glean but the actual collection of events and other metrics will be included in a subsequent PR.

Includes update to metrics.md to add Glean collection and references.

* Add comment clarifying `setUploadEnabled` is called before `initialize`

* Ensure the Glean observer of `recordUsageData` is used on main thread
@kaylagalway kaylagalway added this to the 1.7.2 milestone Jan 8, 2020
@kaylagalway kaylagalway mentioned this issue Feb 7, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@travis79 travis79

Labels
metrics metrics and telemetry related task Issue describes a task that needs to be completed but is not a defect or enhancement in itself.
Projects
None yet
Milestone
1.7.2
Development

No branches or pull requests
3 participants
@ddurst @travis79 @kaylagalway