This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add kebab menu icon and strings. Set up fragment for addition to toolbar. * Create fragment and dialog. * Add confirmation dialog, actions, and presenters * Routing * Ensure item is actually deleted and item list is refreshed before navigating back. * Refactor and remove edit for now * Keeping edit button, just not doing any functionality with it * Test for item detail presenter * Ellipsize long item titles in detail view * Delete confirmation toast * Delete toast and tests * Consumable toast notification for delete * Specify return type on Optional extension * ItemListPresenterTest needed a consumable for the delete toast test * Cleanup * Fix toast notifications
* Reset support when info is null * Reset support every time we sync.
* Add telemetry actions for sync, list update, and error states. * Sync timeout instead of sync end * Add sync complete event * Add errors and ids to telemetry calls
* Update version to 1.1.3 * Add release notes for 1.1.3
* Add more context to release notes * Add descriptions for proguard rules upload.
…865) * Update app services, android components, and megazord configuration * Update a-c to v7.0.0 * Send hashed UID ping when sync completes successfully. * Remove handling for synctelemetryping, to be completed in separate issue. Update AS to 0.37.1
This is something we've been adding to all Readmes of mobile repos to direct people to Pontoon for localization (vs GitHub repos, where work isn't supposed to happen).
* Delete feature flag * Move feature flags to separate support file * Create support to check build configs. Create flags for CUD
* Import strings from android-l10n State: mozilla-l10n/android-l10n@349efdb * Commenting unused string for Espanol
* Remove fake timeout from sync * Remove all sync timeout strings * Rebase and lint
* WIP Automatic FxA sign-in support * Cleanup welcome fragment/account detection * Upgrade to Android Components 9.0.0 * Ensure landable, even if not releasable * gradlew lint
* Edit xml layout * Add route, presenter, and fragment Button clicks and dialog Update dependencies Edit presenter tests Routing stuff Usable state with spinner Buttons working Password visibility in edit mode Lint View Create popup item and insert menu into detail view's kebab buttton * Popup menu and click listener Dropdown menu and formatting Update list - in progress DataStoreTest - mocked up test, stuck on init Datastore update item detail test * Save edited changes Lint Update dependencies Edit unit tests Add sync to datastore editing. Update var name in robot and screenshot tests Reformatting dropdown menu and edit view Adding inclusive popup to edit->detail view nav definition Address nullable server passwords for delete and edit. Remove unused string. Remove learn more clicks from test Refactoring pushError into a helper method.
* Investigation * Add locking routes. * Explicitly ignore autofill on search and edit fields * Ignore autofill on webviews * Remove comments and clean up lint
* Add null text value for empty usernames * gradlew lint
* 907: fix testSettings * fixing routing issues * fixing more routes * changing button name and adding route * fixing conflicts after rebase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.1.4 (Build 4814)
Refine telemetry for sync and fix crashes.
All changes since version 1.1.3: