Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Import strings from android-l10n #900

Merged
merged 3 commits into from
Sep 17, 2019
Merged

Import strings from android-l10n #900

merged 3 commits into from
Sep 17, 2019

Conversation

Pike
Copy link
Contributor

@Pike Pike commented Sep 4, 2019

@Pike Pike added the import-l10n Used by l10n team to track requests across repos (@Pike) label Sep 4, 2019
@Pike Pike requested a review from a team as a code owner September 4, 2019 11:48
@Pike Pike self-assigned this Sep 4, 2019
@eliserichards
Copy link
Contributor

The sync_timeout strings have been removed as part of #791, so they should not be re-added here @Pike

@Pike
Copy link
Contributor Author

Pike commented Sep 5, 2019

The sync_timeout strings have been removed as part of #791, so they should not be re-added here @Pike

We merged that in https://github.com/mozilla-l10n/android-l10n/pull/75/files, which isn't part of this import and will only be impacted if we force-sync from Pontoon to android-l10n.

CC @Delphine

@eliserichards
Copy link
Contributor

Can we force sync so that we have the correct strings @Pike @Delphine?

@Pike
Copy link
Contributor Author

Pike commented Sep 13, 2019

Can we force sync so that we have the correct strings @Pike @Delphine?

I ended up removing them manually on the android-l10n repo, which pontoon syncs from. force-sync didn't end up doing what we had hoped for.

@Pike
Copy link
Contributor Author

Pike commented Sep 13, 2019

Updated the PR.

eliserichards
eliserichards approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @Pike! 🥇

@eliserichards eliserichards merged commit 56c64c6 into mozilla-lockwise:master Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eliserichards eliserichards eliserichards approved these changes

Assignees

@Pike Pike

Labels
import-l10n Used by l10n team to track requests across repos (@Pike)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pike @eliserichards @jhugman