Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox reality quarantine #62

Merged
merged 12 commits into from
Aug 22, 2019
Merged

Firefox reality quarantine #62

merged 12 commits into from
Aug 22, 2019

Conversation

Pike
Copy link
Contributor

@Pike Pike commented Aug 7, 2019

No description provided.

keianhzo and others added 3 commits August 2, 2019 18:49
@keianhzo
Add support for display/voice/content languages (#1474)
68a73e4 
* Add support for display/voice/content languages

* Fixed crash when running using an applicationId suffix

X-Channel-Revision: [master] mozilla-mobile/android-components@8e9cb55
X-Channel-Revision: [master] mozilla-mobile/fenix@093b765
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@a1c7cce
X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@451ce73
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
@MortimerGoro @bluemarvin
Multiwindow implementation (#1467)
6c7436b 
* Remove unused code

* Sessions Multiwindow implementation

Refactor of the current sessions code and added support for multi window.

* Implement window placement logic

* Refactored session settings to SessionManager

Always update all session when a session settings changes

* Keyboard multiwindow placement

* Added support for browser context menus

* Context Menu integration

* Fix parenting bug with three window moves

* Fix relayout on window resize. Set up better anchor points for left/right window resizes.

* Fixed Bookmarks navigation

Also added support for bookmarks in all the windows as stated in the spec: MozillaReality/FirefoxReality#1331

* Close sessions when a window is closed

Now when a window it's closed it's underlying sessions are closed.

* Add new tray icons

* Session restore


wip

* Fix resize gesture flickering and conflicts.

* Added support for restoring private sessions

* Save and restore window sizes

* Set up max reside sizes for multiwindow

* Exit fullscreen when window is closed

Also fixed a regression that made session not to close when a window is closed

* Fix fullscreen mode: hide other windows and make the fullscreened window the front one

* Fixed ADB issue and double loadUri when restoring windows.

* Make max windows dialog match  spec

* Curved mode fixes

* Fix rebase issues

* Fix cylindrical mode math for multiwindow.

* Fixed performance monitor from rebase and added missing tooltips

* Rebase fixes

* New Settings spec rebase fixes

* Added User-Agent multi-window support and fixed session restore issues

The home page was being loaded after a session restore. Now the home page is only loaded if the session is not restored. Also fixed some session restore issues to also restore session settings.

* Fix Tasckluster NoApi compilation issue

* Fixed context menu issues

* More ContextMenu fixes

* Fixed move window buttons get stuck in hover state

Fixes #1482

* Disable left/right move buttons when in private mode single window

* Multi-window Telemetry (#1443)

* Remove unneeded switchBookmarks call which causes a surface resize each time windows are updated

* Dime out world when closing a window

* Rebase fixes

* SessionStore rename

* Fix for session restore in WaveVR

* Fix movable keyboard for multiwindow

* Rebase fixes

X-Channel-Revision: [master] mozilla-mobile/android-components@8e9cb55
X-Channel-Revision: [master] mozilla-mobile/fenix@093b765
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@a1c7cce
X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@f76f19d
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
@keianhzo @bluemarvin
Dialog for requesting permission for storing voice samples (#1507)
0c506f7 
* Added a dialog for requesting permission for storing voice samples

* Do not store samples in private mode

* Continue to voice search if the data collection is not allowed

X-Channel-Revision: [master] mozilla-mobile/android-components@8e9cb55
X-Channel-Revision: [master] mozilla-mobile/fenix@093b765
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@a1c7cce
X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@483f245
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
Pike
Pike commented Aug 7, 2019
View reviewed changes
MozillaReality/FirefoxReality/app/src/main/res/values/strings.xml Outdated
<string name="language_options_content_language">Preferred Language for Displaying Websites: <![CDATA[<br>&emsp;&emsp;<b>%1$s</b>]]></string>

<!-- This string labels the description in the Display Language button in the main language setting dialog. -->
<string name="language_options_display_language">Display Language for App: <![CDATA[<br>&emsp;&emsp;<b>%1$s</b>]]></string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language option strings need changes.

@Pike
Copy link
Contributor Author

Pike commented Aug 7, 2019

Filed MozillaReality/FirefoxReality#1534.

keianhzo and others added 5 commits August 12, 2019 11:15
@keianhzo @bluemarvin
Preferred Languages fixes (#1551)
f203c93 
* Preferred Languages fixes

* Fix last item not being refreshed after and addition

X-Channel-Revision: [master] mozilla-mobile/android-components@8e9cb55
X-Channel-Revision: [master] mozilla-mobile/fenix@093b765
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@a1c7cce
X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@0bf3cb7
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
@keianhzo @bluemarvin
Fixes CDATA issues (#1569)
112ec3d 
X-Channel-Revision: [master] mozilla-mobile/android-components@8e9cb55
X-Channel-Revision: [master] mozilla-mobile/fenix@093b765
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@a1c7cce
X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@eb288bb
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
@jvonitter
string updates
35df6a6 
text string update for jank detector, multiwindow dialog and voice collection UI
X-Channel-Revision: [master] mozilla-mobile/android-components@8e9cb55
X-Channel-Revision: [master] mozilla-mobile/fenix@093b765
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@a1c7cce
X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@dbab195
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
@keianhzo @bluemarvin
Request desktop polishing (#1552)
c289150 
X-Channel-Revision: [master] mozilla-mobile/android-components@8e9cb55
X-Channel-Revision: [master] mozilla-mobile/fenix@093b765
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@a1c7cce
X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@5b22a06
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
@jvonitter @bluemarvin
additional minor strings changes (#1577)
64cadee 
X-Channel-Revision: [master] mozilla-mobile/android-components@8e9cb55
X-Channel-Revision: [master] mozilla-mobile/fenix@093b765
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@a1c7cce
X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@9e9fa00
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
Delphine
Delphine requested changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@Delphine Delphine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jvonitter @keianhzo: There are a few things to update in this export (and one pending question to Pike).
Do you prefer I file an issue for these in your repo - or is this enough and we'll wait for further commits fixing these?
thanks!

MozillaReality/FirefoxReality/app/src/main/res/values/strings.xml Outdated
@@ -662,7 +728,7 @@

<!-- This string is for the tooltip that appears upon hovering the 'User Agent' button in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment here needs to be updated.
Also, since the string changes drastically in meaning, the string ID will need to be updated so that localizers can see it has changed.

The strings that have been modified below all need to be fixed in the same way (so, updating localization comment as well as string ID).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these are new strings in 1.4 and haven't been translated yet (at least the translations haven't been comited to the FxR repo yet). Do we still need to add new strings even if they have only changed before being translated?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I see it landed and localized on our side. See French here: https://pontoon.mozilla.org/fr/android-l10n/MozillaReality/FirefoxReality/app/src/main/res/values/strings.xml/?search=user_agent_tooltip&string=200838

MozillaReality/FirefoxReality/app/src/main/res/values/strings.xml Outdated
<string name="voice_samples_collect_dialog_description">Your data is always anonymous and protected under our Personal Data Promise. We collect voice samples to improve the experience and performance of our products. You’ll always be able to use voice search, even if you don’t allow collection.&lt;a href=&quot;privacy&quot;&gt;Learn More&lt;/a&gt;</string>

<!-- This string is displayed in the button of the Voice Search samples collect dialog.
When clicked the user opts out from the voice data collection. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "opts in" since the string is "Allow"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

MozillaReality/FirefoxReality/app/src/main/res/values/strings.xml Outdated
<string name="voice_samples_collect_dialog_allow">Allow</string>

<!-- This string is displayed in the button of the Voice Search samples collect dialog.
When clicked the user opts in for the voice data collection. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "opts out" since the string is "Don't Allow"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

MozillaReality/FirefoxReality/app/src/main/res/values/strings.xml Outdated
<string name="performance_message">Try reducing the window size to improve performance. Unblocking this page may crash your app.</string>

<!-- This string is displayed anywhere where we need to display the "Default" string by itself. -->
<string name="tag_default">Default</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to do this.
@Pike : Could you please confirm?
(also I see there's another "default" string below, so not sure this is useful)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed that string as it's not being used.

@keianhzo
Copy link
Contributor

@Delphine I've address the issues above in MozillaReality/FirefoxReality#1601

Let me know about #62 (comment) so I can update the PR if necessary.

@keianhzo keianhzo mentioned this pull request Aug 20, 2019
Merged
@jvonitter @bluemarvin
Update voice collection strings (#1611)
b5f68a6 
Updating legal language around voice collection permissions
X-Channel-Revision: [master] mozilla-mobile/android-components@8e9cb55
X-Channel-Revision: [master] mozilla-mobile/fenix@093b765
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@a1c7cce
X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@374e9aa
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
Delphine
Delphine requested changes Aug 20, 2019
View reviewed changes
MozillaReality/FirefoxReality/app/src/main/res/values/strings.xml Outdated
@@ -662,7 +728,7 @@

<!-- This string is for the tooltip that appears upon hovering the 'User Agent' button in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I see it landed and localized on our side. See French here: https://pontoon.mozilla.org/fr/android-l10n/MozillaReality/FirefoxReality/app/src/main/res/values/strings.xml/?search=user_agent_tooltip&string=200838

@keianhzo @bluemarvin
Replace all the hardcoded Firefox strings (#1612)
2f5cd9f 
* Replace all the hardcoded Firefox strings

* Updated modified strings id

X-Channel-Revision: [master] mozilla-mobile/android-components@8e9cb55
X-Channel-Revision: [master] mozilla-mobile/fenix@093b765
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@a1c7cce
X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@8f83e2f
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
@keianhzo @bluemarvin
L10n fixes (#1601)
79cf62a 
* L10n fixes

* Replace request desktop tooltip string

X-Channel-Revision: [master] mozilla-mobile/android-components@8e9cb55
X-Channel-Revision: [master] mozilla-mobile/fenix@093b765
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@a1c7cce
X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@fe39b27
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
@Delphine Delphine merged commit 03e314c into master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keianhzo keianhzo keianhzo left review comments

@Delphine Delphine Delphine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pike @keianhzo @Delphine @MortimerGoro @jvonitter @bluemarvin