Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong grammatical number in string for Firefox Reality? #99

Closed
jakobkappel opened this issue Oct 25, 2019 · 6 comments · Fixed by MozillaReality/FirefoxReality#3451
Closed

Comments

@jakobkappel
Copy link
Contributor

Skærmbillede 2019-10-25 kl  13 31 22

appears to refer to

Skærmbillede 2019-10-25 kl  13 31 53

If that is the case "them" should probably be "it".

@Delphine
Copy link
Contributor

CC @jvonitter for input.
Thanks for filing Jakob :)

@keianhzo
Copy link
Contributor

keianhzo commented Jun 2, 2020

@flodolo As there can be multiple popups at the same time I think the correct would be:
%1$s prevented pop-ups from this site
I guess we need to update the key as this string is already translated, right?

@flodolo
Copy link
Contributor

flodolo commented Jun 2, 2020

I guess we need to update the key as this string is already translated, right?

Yes, that's correct.

@flodolo
Copy link
Contributor

flodolo commented Jun 2, 2020

Fixed in a0d5a48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants