Skip to content

Commit

Permalink
[components] For mozilla-mobile/android-components#8565 - New RepostP…
Browse files Browse the repository at this point in the history
…rompt that inform if users don't proceed with reload

The prompt for a repost request was previously an instance of Confirm, type
used for many other requests.
We'll now use a new Repost type that allows easily identifying the particular
scenario for a repost request, prompt that will now show a slightly different
text and will notify engine observers of "onRepostPromptCancelled" when users
asked to refresh the page but then cancelled that operation in the repost
prompt, callback used to hide the pull to refresh throbber.

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@7972762
  • Loading branch information
Mugurell authored and mergify[bot] committed Oct 16, 2020
1 parent 3b93477 commit 543d6b9
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "mozilla-mobile/firefox-android/android-components",
"revs": {
"main": "088830be88028f93779387e0a398a7e1667c6356"
"main": "79727628dd050b754467c09c0943cd271a6208a9"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,12 @@
<string name="mozac_feature_prompts_collapse_logins_content_description">Collapse suggested logins</string>
<!-- Header for the select login prompt to allow users to fill a form with a saved login -->
<string name="mozac_feature_prompts_saved_logins">Suggested logins</string>

<!-- Strings shown in a dialog that appear when users try to refresh a certain kind of webpages -->
<string name="mozac_feature_prompt_repost_title">Resend data to this site?</string>
<string name="mozac_feature_prompt_repost_message">Refreshing this page could duplicate recent actions, such as sending a payment or posting a comment twice.</string>
<!-- Pressing this will dismiss the dialog and reload the page sending again the previous data -->
<string name="mozac_feature_prompt_repost_positive_button_text">Resend data</string>
<!-- Pressing this will dismiss the dialog and not refresh the webpage -->
<string name="mozac_feature_prompt_repost_negative_button_text">Cancel</string>
</resources>

0 comments on commit 543d6b9

Please sign in to comment.