l10n title/description for install.rdf like nodejs

[jc3213]

This is based on #419 , But the original one have more than one additional functions and most of them need more tweak to be done. So I've rewritten the l10n part according to jpm code style(maybe?)

[jc3213]

Here's a sample to test the functional https://github.com/jc3213/jpm/releases/download/1.0.5/test.zip
Sorry that I don't have a github client, and can't attach files to the comment(due to my network provider)

@kumar303 Will you please have a look into this?

[johannhof]

Yay, thanks for doing this. 👍 This would fix #479. You should probably add a test if this works properly, though.

[jc3213]

@johannhof That's been done, please have a look into it

[jc3213]

I've added the original title and description in order to fulfill the complete test that if only title/description get localized. If so get original description/title.

For example: "locales": "ja": {"title": "ja localed title"} or "locales": "ja": {"description": "ja localed description"}

[johannhof]

nit: || undefined can be removed here

[jc3213]

I did keep that to match line 52 "em:description": manifest.description || undefined, I think It should be better to let it this way

[johannhof]

yeah, no idea what jsontoxml does for other falsy values, so it's probably best to leave it

[jc3213]

I've changed them to jetpackMeta["em:name"] and jetpackMeta["em:description"], and in this way its faster than calculate the name and description again

[jc3213]

@johannhof @kumar303 this pull requests couldn't solve contributors, developers, and translators tags, I've done another one but the generated install.rdf has too much CRLF but it supports contributors, developers, and translators tags. See https://github.com/jc3213/jpm/commit/f3e65852c468d4a01544db1f0e0643c38b749ec2

According to document on MDN about package.json https://developer.mozilla.org/en-US/Add-ons/SDK/Tools/package_json It seems there is no need to support contributors, no info about developers and do support translators. It's really a headache

          <em:localized>
            <Description>
                <em:locale>ja</em:locale>

                <em:name>ja addon name</em:name>

                <em:description>ja addon desc</em:description>

                <em:creator>author</em:creator>

                <em:homepageURL>homepage</em:homepageURL>

</Description>
</em:localized>

[kumar303]

all variables typically follow camel case format, such as localeJa.

[jc3213]

@kumar303 That has been done

[kumar303]

Thanks for all your work on this and sorry about the headaches

[asamuzaK]

Thanks for the fix.
It should be documented too.
package.json - Mozilla | MDN

[kumar303]

Yes. Could someone edit MDN to add documentation? It's like a wiki so anyone can edit it.

[SebastianZ]

If I read the patch correctly, it allows to add the localization directly within the package.json using the locales property.
Though it doesn't allow to have the translations within the .properties files as initially requested, i.e. as <add-on name>.title=Title and <add-on name>.description=Description. Is that correct?
And if so, should I create a new issue for changing that/adding this as a second way?

Sebastian

[kumar303]

yes, please create a new issue

[SebastianZ]

Thanks for the quick answer! I've created #527.

Sebastian

[SebastianZ]

Thanks for the fix.
It should be documented too.
package.json - Mozilla | MDN

Done:

• package.json - Mozilla | MDN
• Localization - Mozilla | MDN

Sebastian

[kumar303]

The docs look great! Thank you