Skip to content
This repository has been archived by the owner on Nov 27, 2019. It is now read-only.

Run changelog lint pre-push? #594

Open
freaktechnik opened this issue Oct 6, 2016 · 6 comments
Open

Run changelog lint pre-push? #594

freaktechnik opened this issue Oct 6, 2016 · 6 comments

Comments

@freaktechnik
Copy link
Contributor

I think running the changelog lint pre-push would make sense. Maybe some of the current checks could be removed, not sure how important it is to check the spelling of the README on every push.

@kumar303
Copy link
Contributor

kumar303 commented Oct 6, 2016

Hah, yeah, I'd like to not check the spelling of the README. It's annoying to add new non-dictionary words too. I would accept a patch to remove all things spell check related :) It's open source, someone will correct our typos eventually.

I added a commit-msg pre-commit hook to web-ext. I think this works really well but the only catch is it doesn't run on Windows. I would be fine if someone ported it to jpm anyway though.

@freaktechnik
Copy link
Contributor Author

I think husky, the thing used for pre-push hooks in jpm would also work with pre-commit hooks.

@kumar303
Copy link
Contributor

kumar303 commented Oct 6, 2016

oh yeah duh, forgot we already had that

@kumar303
Copy link
Contributor

Is husky Windows compatible? A web-ext contributor just found git-hooks-win which is both -nix and Windows compatible: mozilla/web-ext#561

@freaktechnik
Copy link
Contributor Author

From this commit I'd assume it at least tries to be compatible: typicode/husky@100ad1e

@kumar303
Copy link
Contributor

looks promising!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants