-
Notifications
You must be signed in to change notification settings - Fork 75
Run changelog lint pre-push? #594
Comments
Hah, yeah, I'd like to not check the spelling of the README. It's annoying to add new non-dictionary words too. I would accept a patch to remove all things spell check related :) It's open source, someone will correct our typos eventually. I added a commit-msg pre-commit hook to web-ext. I think this works really well but the only catch is it doesn't run on Windows. I would be fine if someone ported it to jpm anyway though. |
I think husky, the thing used for pre-push hooks in jpm would also work with pre-commit hooks. |
oh yeah duh, forgot we already had that |
Is husky Windows compatible? A web-ext contributor just found git-hooks-win which is both -nix and Windows compatible: mozilla/web-ext#561 |
From this commit I'd assume it at least tries to be compatible: typicode/husky@100ad1e |
looks promising! |
I think running the changelog lint pre-push would make sense. Maybe some of the current checks could be removed, not sure how important it is to check the spelling of the README on every push.
The text was updated successfully, but these errors were encountered: