feat: add render and diff helm action #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts, using summary comments instead of full blocks, excluding empty files from diff comments
dlactin
changed the title
jasonthomas
reviewed
Mar 6, 2024
| for chart in ${{ needs.get_changed_helm_charts.outputs.charts }}; do | ||
| chart_diff_output=$(diff -r "shared/base-charts/${chart}" "shared/head-charts/${chart}" || true) | ||
| if [ -n "$chart_diff_output" ]; then | ||
| echo -e "Changes found in chart: ${chart}\n$(diff -ru shared/base-charts/${chart} shared/head-charts/${chart})\n" >> diff.log |
There was a problem hiding this comment.
The unified context for diff shows the new changes with a time of the beginning of epoch. Although I am not sure how to make this any better, just a note since it could be confusing. I looked through diff man page for other alternates, but nothing comes to mind. I think for now it's fine the way it is.
There was a problem hiding this comment.
We could potentially use git diff -u --no-index instead which will not have timestamps
jasonthomas
approved these changes
Mar 6, 2024
|
🎉 This PR is included in version 3.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new reusable action to render helm charts on both base and head refs, then post the diff as a comment or comments on the associated pull request.
There are a few changes here from what I demoed in the sandbox:
This slows down smaller changes but significantly improves performance when multiple charts need to be rendered
This is using a function adapted from the Atlantis SplitComment code to ensure we are sending comments within the limits defined by GitHub, I have also reused the summary and sep additions to string comments together.