-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up profile sections a little bit. #452
Conversation
fiji-flo
commented
Aug 26, 2019
- tiny refactor to enable preview as
- more clean up shall follow
- tiny refactor to enable preview as - more clean up shall follow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in general, a lot of these change suggestions are just "more refactoring" that we could decide to maybe be done at a later stage, or do them right now too.
</IconBlockList> | ||
</div> | ||
<div v-if="accounts.other.length"> | ||
<h3>Elsewhere</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
@@ -1,13 +1,5 @@ | |||
<template> | |||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this wasn't part of your code change, but since we are refactoring, this isn't a huge breaking issue, but I have a personal problem with classless divs. To me, they are meaningless markup and only provide functional structure. In my experience, if you see a plac where you have a classeless/idless div, there might be either a better html tag or a different way to setup the markup - personal opinion :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe for consistency sake, just give it a class of like profile__contact
@andrew-sunada I addressed the CSS class handling. I won't clean up the individual components. I tried to touch them as little as necessary. But I agree, we should deal with that at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just like to clean up this little bit of html if that's alright. I know I can be kinda picky with html.
All blockers resolved remaining cleanup will be follow up work. Merging to get it to QA. |