Fix: Remove error in console

[aryamanpuri]

For taskcluster/taskcluster#2263
@helfi92

[helfi92]

We should just do:

diff --git a/src/components/MarkdownTextArea/index.jsx b/src/components/MarkdownTextArea/index.jsx
index ec0c9e5..100dc72 100644
--- a/src/components/MarkdownTextArea/index.jsx
+++ b/src/components/MarkdownTextArea/index.jsx
@@ -107,8 +107,7 @@ export default class MarkdownTextArea extends Component {
   };
 
   render() {
-    const { classes, rows, markdownProps } = this.props;
-    const { onChange, defaultTabIndex, ...props } = this.props;
+    const { classes, rows, markdownProps, onChange, defaultTabIndex, ...props } = this.props;
     const { tabIndex, value } = this.state;
     const isPreview = tabIndex === 1;

[aryamanpuri]

@helfi92 Error is of changing MarkdownProps to Markdownprops.

[helfi92]

Do you still see the error after implementing the diff mentioned above? You can test it by running the components styleguide. https://github.com/mozilla-frontend-infra/components/blob/master/README.md#development-and-contributing

[aryamanpuri]

Can you explain to me this, why is the error not showing now ?

[helfi92]

It's because markdownProps was being fed to the TextField component. markdownProps is not defined in TextField...

render() {
  const { classes, rows, markdownProps } = this.props;
  const { onChange, defaultTabIndex, ...props } = this.props;
  
  // ...
    
  <TextField
    name="Write"
    onChange={this.handleValueChange}
    fullWidth
    multiline
    rows={rows}
    // ...props  will have markdownProps which is not defined in TextField
    {...props}
    value={props.value || value}
/>
  }

[helfi92]

Could you rename the pull-request to follow the convention we use for this repo? https://github.com/mozilla-frontend-infra/components#committing-and-pushing-changes Thanks!

[aryamanpuri]

Could you rename the pull-request to follow the convention we use for this repo? https://github.com/mozilla-frontend-infra/components#committing-and-pushing-changes Thanks!

Done

[helfi92]

Great work!

[helfi92]

🎉 This PR is included in version 3.0.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀