fix: Use AppProvidedSearchEngine when extracting the engine configurations for better accuracy. #208
+33
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions for better accuracy. This change will make it so that we process the received configuration with AppProvidedSearchEngine and ensure that the values that we display on the UI are the same as the application would have internally. This also makes it so that we get the URL data at the same time, which simplifies the display mechanism and calls to the back end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make it so that we process the received configuration with
AppProvidedSearchEngineand ensure that the values that we display on the UI are the same as the application would have internally.This also makes it so that we get the URL data at the same time, which simplifies the display mechanism and calls to the back end.
I decided to do this because of the Rust changes, which will slightly change how the engine selector is returning the engine objects. Using
AppProvidedSearchEnginewill mean the searchengine-devtools uses the correct values from the application, and we won't have to keep it in sync.I'm also bumping the versions here in preparation for a new release, once we land the current PRs.