-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
76 add google colab notebook demo #77
Conversation
f708f4b
to
d1af435
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daavoo - Tested this and it worked well on the T4 GPU.
The addition of the content tabs in the Docs looks great!
One minor change I think we should implement - in both the Docs and the Colab Notebook, I think we should be explicit about the user ensuring they change the Colab runtime to a GPU - as it defaults to a CPU, and if they dont change it, it will break. Something like:
"This notebook requires a GPU runtime to function correctly. Using a CPU runtime will result in errors.
How to Switch to GPU:
1. Go to Runtime > Change runtime type in the top menu.
2. Set Hardware accelerator to GPU.
3. Click Save.
"
@stefanfrench I updated the notebook adding a text paragraph and also a python code that will crash if the GPU is not enabled: I think it is enough to have that in the notebook and something in the docs would be kind of redundant, but I can also update the docs if you think is a blocker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daavoo - thanks for adding the GPU check, works great! Approved.
Added demo/notebook.ipynb
Test from this branch:
https://colab.research.google.com/github/mozilla-ai/document-to-podcast/blob/76-add-google-colab-notebook-demo/demo/notebook.ipynb
Updated setup instructions
Update to use https://squidfunk.github.io/mkdocs-material/reference/content-tabs/.
Check the docs updates: