Enable user to exit podcast generation gracefully #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanfrench
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
@Kostis-S-Z - tested this and worked as expected - approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
While developing #72 , I implemented this tiny feature because it made testing easier.
Basically, wrap the podcast generation loop in a
try/exceptso that the user canCtrl+Cin the terminal and exit, while saving the generated podcast up that point. I thought maybe its useful to have in general.How to test it
Steps to test the changes:
pip install -e .document-to-podcast --from_config example_data/config.yamlpodcast.txtandpodcast.wavwas created with the podcast generated up to that pointAdditional notes for reviewers
[N/A]
I already...
/docs)