Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Symbol.toStringTag] getter seems to interfer with chai's deep.equal check #27

Open
Gozala opened this issue Jun 24, 2020 · 0 comments
Open

Comments

@Gozala
Copy link

Gozala commented Jun 24, 2020

As per ipld/js-ipld-dag-pb#184 (comment) it appears that chai will deep equality check with duck typed counterpart of the instance because of the [Symbol.toStringTag] getter this library adds.

I have created pull request to illustrate this #26, although this library uses jest instead of chai same issue appears to manifest. Unwapped class does not seem to exhibit this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant