Refactor everything to use correct canonical OS directories #96
Conversation
| let preference_dir = project_dirs().preference_dir(); | ||
| // TODO: this is overkill to create the directory every time. | ||
| // This should be done somewhere during init, but I'm not sure where. | ||
| std::fs::create_dir_all(&preference_dir).unwrap_or_else(|_| |
There was a problem hiding this comment.
The actual folder creation (if needed) is done in a previous call to setup_model_downloads_folder (see https://github.com/moxin-org/moxin/pull/96/files#diff-9cac44800b86084f5e0e0a00ab63cc15615598154b89126aea415e93019b7ca0R25)
So this line sounds like a duplication.. I'm pretty sure everything should work removing this line, but maybe you can confirm
There was a problem hiding this comment.
I tested it because I didn't understand why it was not failing after being invoked more than once. I've just convinced to myself that std::fs::create_dir_all is not erroring when the folder already exists (although it is hard to confirm from the docs!).
So, we can remove this line later, but no real harm.
There was a problem hiding this comment.
we can't remove this line, but it should be moved elsewhere. Previously when everything was in the user's $HOME directory, a single call covered it. But in this case, the preferences directory may be in a completely different location than the app's data directory, so we need at least one call to fs::create_dir_all().
There was a problem hiding this comment.
btw, without this line here, i get a runtime panic on my mac.
There was a problem hiding this comment.
I've just convinced to myself that
std::fs::create_dir_allis not erroring when the folder already exists (although it is hard to confirm from the docs!).
yes that is correct, that's the behavior of mkdir -p on Unix-like OSes.
No description provided.