Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Refunder and Asserts on cancel and refund #98

Closed
wants to merge 11 commits into from

Conversation

Primata
Copy link

@Primata Primata commented Nov 12, 2024

Description

Adds a Refunder role to Bridge Configs.
This Refunde is the only allowed party to call refund_bridge_transfer and cancel_bridge_transfer

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Not yet tested

Key Areas to Review

Include framework tests
Test Within the rest of the bridge framework

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@franck44
Copy link

@0xPrimata Where is the issue that explains the problem and why we need these changes?

@Primata Primata closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace OwnableUpgradeable with AccessControlUpgradeable in Bridge Contracts
3 participants